From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752008AbaIVCDe (ORCPT ); Sun, 21 Sep 2014 22:03:34 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:54589 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbaIVCDc (ORCPT ); Sun, 21 Sep 2014 22:03:32 -0400 Message-ID: <541F8370.4040705@gmail.com> Date: Sun, 21 Sep 2014 22:03:28 -0400 From: nick User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Peter Chen , "gregkh@linuxfoundation.org" CC: "julia.lawall@lip6.fr" , "oneukum@suse.de" , "himangi774@gmail.com" , "stern@rowland.harvard.edu" , "paul.gortmaker@windriver.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: FIX ME in oxu210p-hcd.c References: <541DB6BF.7090909@gmail.com> <541DB8C1.2000101@gmail.com> <2d062bb368d94327b89cba3d547bff9d@BN1PR0301MB0772.namprd03.prod.outlook.com> In-Reply-To: <2d062bb368d94327b89cba3d547bff9d@BN1PR0301MB0772.namprd03.prod.outlook.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-09-21 07:53 PM, Peter Chen wrote: > > >> Subject: Re: FIX ME in oxu210p-hcd.c >> >> >> I found a unfixed FIX ME in the file stated in my above message. I am >> wondering what to set hcd->self.comtroller->dma_mask to as it's now been >> defined to NULL and clearly even as a newbie this seem incorrect. >> Regards Nick > > Usually, it is set at its controller driver or pass through through device tree or > platform data. > > Peter > Sorry Peter, I apologize for asking for more help here but I will paste the function below and with my changes. Please let me known if I am wrong and how to fix it as I new here. Sorry for Wasting Your Time, Nick static int oxu_reset(struct usb_hcd *hcd) { struct oxu_hcd *oxu = hcd_to_oxu(hcd); int ret; spin_lock_init(&oxu->mem_lock); INIT_LIST_HEAD(&oxu->urb_list); oxu->urb_len = 0; - /* FIMXE */ + hcd->self.controller->dma_mask = hcd->regs; if (oxu->is_otg) { oxu->caps = hcd->regs + OXU_OTG_CAP_OFFSET; oxu->regs = hcd->regs + OXU_OTG_CAP_OFFSET + \ HC_LENGTH(readl(&oxu->caps->hc_capbase)); oxu->mem = hcd->regs + OXU_SPH_MEM; } else { oxu->caps = hcd->regs + OXU_SPH_CAP_OFFSET; oxu->regs = hcd->regs + OXU_SPH_CAP_OFFSET + \ HC_LENGTH(readl(&oxu->caps->hc_capbase)); oxu->mem = hcd->regs + OXU_OTG_MEM; } oxu->hcs_params = readl(&oxu->caps->hcs_params); oxu->sbrn = 0x20; ret = oxu_hcd_init(hcd); if (ret) return ret; return 0; }