From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbaIVCRo (ORCPT ); Sun, 21 Sep 2014 22:17:44 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:42328 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbaIVCRm (ORCPT ); Sun, 21 Sep 2014 22:17:42 -0400 Message-ID: <541F86C2.80306@gmail.com> Date: Sun, 21 Sep 2014 22:17:38 -0400 From: nick User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "gregkh@linuxfoundation.org" CC: Peter Chen , "julia.lawall@lip6.fr" , "oneukum@suse.de" , "himangi774@gmail.com" , "stern@rowland.harvard.edu" , "paul.gortmaker@windriver.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: FIX ME in oxu210p-hcd.c References: <541DB6BF.7090909@gmail.com> <541DB8C1.2000101@gmail.com> <2d062bb368d94327b89cba3d547bff9d@BN1PR0301MB0772.namprd03.prod.outlook.com> <541F8370.4040705@gmail.com> <20140922021159.GA28285@kroah.com> In-Reply-To: <20140922021159.GA28285@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-09-21 10:11 PM, gregkh@linuxfoundation.org wrote: > On Sun, Sep 21, 2014 at 10:03:28PM -0400, nick wrote: >> >> >> On 14-09-21 07:53 PM, Peter Chen wrote: >>> >>> >>>> Subject: Re: FIX ME in oxu210p-hcd.c >>>> >>>> >>>> I found a unfixed FIX ME in the file stated in my above message. I am >>>> wondering what to set hcd->self.comtroller->dma_mask to as it's now been >>>> defined to NULL and clearly even as a newbie this seem incorrect. >>>> Regards Nick >>> >>> Usually, it is set at its controller driver or pass through through device tree or >>> platform data. >>> >>> Peter >>> >> Sorry Peter, >> I apologize for asking for more help here but I will paste the function below and with my changes. >> Please let me known if I am wrong and how to fix it as I new here. >> Sorry for Wasting Your Time, > > Then please do not. Just because your other email addresses were banned > from lkml, don't keep popping up and bothering people, it's rude, and > will cause this address to be banned as well. > Sorry Greg, I don't want to get banned again. I was trying to help out and learn, I was apologizing not for wasting time as much as for making sure I wasn't wasting maintainer time again. I also am coming to the conclusion that my terrible patches were a waste of time and I am trying to get back into helping out. Cheers, Nick