linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris J Arges <chris.j.arges@canonical.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vget.kernel.org, bruce.lucas@mongodb.com,
	Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
	Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
	Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
	Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
	MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mptfusion: enable no_write_same in scsi_host_template
Date: Mon, 22 Sep 2014 13:17:01 -0500	[thread overview]
Message-ID: <5420679D.3070406@canonical.com> (raw)
In-Reply-To: <20140922180220.GA10166@infradead.org>



On 09/22/2014 01:02 PM, Christoph Hellwig wrote:
> On Mon, Sep 22, 2014 at 12:56:59PM -0500, Chris J Arges wrote:
>> When using a virtual SCSI disk in a VMWare VM if blkdev_issue_zeroout is used
>> data can be improperly zeroed out using the mptfusion driver. This patch
>> disables write_same for this driver which ensures that manual zeroing out
>> is used instead.
> 
> Does this affet real hardware or is it a VMware bug?  If it's just the
> latter we should simply blacklist VMware.
> 
I've only been able to reproduce this on VMWare. There is a pretty
straightforward reproducer in the BugLink if there is any interest in
verifying on hardware.

How would you recommending blacklisting only VMWare guests in this case?

Thanks,
--chris j arges

  reply	other threads:[~2014-09-22 18:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 17:56 [PATCH] mptfusion: enable no_write_same in scsi_host_template Chris J Arges
2014-09-22 18:02 ` Christoph Hellwig
2014-09-22 18:17   ` Chris J Arges [this message]
2014-09-22 18:19     ` Christoph Hellwig
2014-09-22 18:50       ` Chris J Arges
2014-09-22 20:44       ` [PATCH v2] mptfusion: enable no_write_same for vmware scsi disks Chris J Arges
2014-09-22 20:54         ` Chris J Arges
2014-09-23  7:11         ` Christoph Hellwig
2014-09-23 14:22           ` [PATCH v3] " Chris J Arges
2014-09-23 15:29             ` Chris J Arges
2014-09-23 22:11             ` Chris J Arges
2014-09-23 23:28               ` Martin K. Petersen
2014-09-24  8:18                 ` Christoph Hellwig
2014-09-24 15:11                   ` Martin K. Petersen
2014-09-25 17:01             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5420679D.3070406@canonical.com \
    --to=chris.j.arges@canonical.com \
    --cc=MPT-FusionLinux.pdl@avagotech.com \
    --cc=abhijit.mahajan@avagotech.com \
    --cc=bruce.lucas@mongodb.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-scsi@vget.kernel.org \
    --cc=nagalakshmi.nandigama@avagotech.com \
    --cc=praveen.krishnamoorthy@avagotech.com \
    --cc=sreekanth.reddy@avagotech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).