From: Douglas Gilbert <dgilbert@interlog.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
"Elliott, Robert (Server Storage)" <elliott@hp.com>
Subject: Re: two more fixes for block/for-linus
Date: Mon, 22 Sep 2014 14:40:15 -0400 [thread overview]
Message-ID: <54206D0F.1010506@interlog.com> (raw)
In-Reply-To: <54202CF9.7050303@kernel.dk>
On 14-09-22 10:06 AM, Jens Axboe wrote:
> On 2014-09-22 07:59, Christoph Hellwig wrote:
>> Fix two regressions with the timer/blk_mq_start_request changes found
>> when using scsi-mq on an ATA device.
>>
>> Note that given how late we are in the cycle I wonder if we really should
>> push the changes in block/for-linus to Linus in this cycle. The race
>> part of the timer fixes is extremly narrow, and the reserved request
>> part of it requires an out of tree driver update to trigger it, so it
>> doesn't sound super criticial.
>
> I was planning on pushing it out today, I've run a lot of testing on it
> internally last week. Ho hum, let me think about it...
With these patches applied (actually a resync an hour
ago with the for-linus tree which includes them), the
freeze-during-boot-up problem that I have been seeing
with an old SATA boot disk (perhaps 1.5 Gbps) for
the last two weeks, has gone away.
That SATA disk is connected to the motherboard (Gigabyte
Z97M-D3H/Z97M-D3H, BIOS F5 05/30/2014) and has a standard
AHCI interface as far as I can tell. dmesg confirms that.
Please add "Tested-by: Douglas Gilbert <dgilbert@interlog.com>"
to Christoph's "two more fixes for block/for-linus" series.
Doug Gilbert
next prev parent reply other threads:[~2014-09-22 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 13:59 two more fixes for block/for-linus Christoph Hellwig
2014-09-22 13:59 ` [PATCH 1/2] block: fix blk_abort_request on blk-mq Christoph Hellwig
2014-09-22 14:08 ` Jens Axboe
2014-09-22 13:59 ` [PATCH 2/2] scsi: move blk_mq_start_request call earlier Christoph Hellwig
2014-09-22 14:06 ` two more fixes for block/for-linus Jens Axboe
2014-09-22 18:40 ` Douglas Gilbert [this message]
2014-09-23 5:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54206D0F.1010506@interlog.com \
--to=dgilbert@interlog.com \
--cc=axboe@kernel.dk \
--cc=elliott@hp.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox