From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753815AbaIWGQr (ORCPT ); Tue, 23 Sep 2014 02:16:47 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:45694 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbaIWGQp (ORCPT ); Tue, 23 Sep 2014 02:16:45 -0400 Message-ID: <54211032.6010009@st.com> Date: Tue, 23 Sep 2014 08:16:18 +0200 From: Giuseppe CAVALLARO User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Beniamino Galvani , Cc: "David S. Miller" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Carlo Caione , Jerry Cao , Victor Wan , , Subject: Re: net: stmmac glue layer for Amlogic Meson SoCs References: <1411219757-9201-1-git-send-email-b.galvani@gmail.com> In-Reply-To: <1411219757-9201-1-git-send-email-b.galvani@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.138.72] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52,1.0.28,0.0.0000 definitions=2014-09-23_03:2014-09-23,2014-09-23,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/2014 3:29 PM, Beniamino Galvani wrote: > Hi, > > the Ethernet controller available in Amlogic Meson6 and Meson8 SoCs is > a Synopsys DesignWare MAC IP core, already supported by the stmmac > driver. > > These patches add a glue layer to the driver for the platform-specific > settings required by the Amlogic variant. > > This has been tested on a Amlogic S802 device with the initial Meson > support submitted by Carlo Caione [1]. patches look fine just a warning with checkpatch as shown below then Acked-by: Giuseppe Cavallaro [cavagiu@lxmcdt5 net.git]$ git-format-patch -2 0001-net-stmmac-add-Amlogic-Meson-glue-layer.patch 0002-net-stmmac-meson-document-device-tree-bindings.patch [cavagiu@lxmcdt5 net.git]$ !./ ./scripts/checkpatch.pl 000* WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 WARNING: DT compatible string vendor "amlogic" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt #152: FILE: drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:34: + { .compatible = "amlogic,meson6-dwmac", .data = &meson6_dwmac_data}, total: 0 errors, 2 warnings, 0 checks, 108 lines checked 0001-net-stmmac-add-Amlogic-Meson-glue-layer.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 25 lines checked 0002-net-stmmac-meson-document-device-tree-bindings.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. > > [1] http://lwn.net/Articles/612000/ > > Beniamino Galvani (2): > net: stmmac: add Amlogic Meson glue layer > net: stmmac: meson: document device tree bindings > > .../devicetree/bindings/net/meson-dwmac.txt | 25 ++++++++ > drivers/net/ethernet/stmicro/stmmac/Kconfig | 10 ++++ > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + > drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 67 ++++++++++++++++++++++ > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 + > .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 + > 6 files changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/meson-dwmac.txt > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c >