From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756256AbaIWQkw (ORCPT ); Tue, 23 Sep 2014 12:40:52 -0400 Received: from mail-we0-f180.google.com ([74.125.82.180]:46654 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755486AbaIWQku (ORCPT ); Tue, 23 Sep 2014 12:40:50 -0400 Message-ID: <5421A28E.7060600@gmail.com> Date: Tue, 23 Sep 2014 18:40:46 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org CC: thomas.petazzoni@free-electrons.com, zmxu@marvell.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, Antoine Tenart , linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, jszhang@marvell.com Subject: Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller References: <1411474536-22626-1-git-send-email-antoine.tenart@free-electrons.com> <4014272.rJbSfrLcuB@wuerfel> <542195B0.6080706@gmail.com> <9401592.hUYDkriFVO@wuerfel> In-Reply-To: <9401592.hUYDkriFVO@wuerfel> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2014 06:29 PM, Arnd Bergmann wrote: > On Tuesday 23 September 2014 17:45:52 Sebastian Hesselbarth wrote: >> For reference, this is what we have for MVEBU SoCs with multiple ports >> per controller: >> >> eth: ethernet-ctrl@72000 { >> compatible = "marvell,orion-eth"; ... >> reg = <0x72000 0x4000>; ... >> >> ethernet-port@0 { >> compatible = "marvell,orion-eth-port"; ... >> phy-handle = <ðphy>; >> }; >> }; >> >> mdio: mdio-bus@72004 { >> compatible = "marvell,orion-mdio"; ... >> reg = <0x72004 0x84>; .. >> ethphy: ethernet-phy { >> /* set phy address in board file */ >> }; >> }; > But in this example, you have the same registers and the same > clocks in two nodes, which are even used by the same device driver > at the moment. It's not a big issue, but my feeling is that Antoine's > approach was actually better because it more closely reflects > the way that the hardware is built. I was not referring to the separate mdio bus node, but putting the ethernet-phy node as a child of ethernet-ctrl. Anyway, I can live with the ethernet-phy being a child of the controller node until we discover where it is hooked up. For the internal MII PHY the controller node maybe is the only sane place to put it in. The HEC PHY will reside within the CEC IP node but that is compatible with Antoine's proposal. Sebastian