public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joseph Salisbury <joseph.salisbury@canonical.com>
To: jlayton@redhat.com
Cc: sfrench@samba.org, linux-cifs@vger.kernel.org,
	samba-technical@lists.samba.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: [Regression]  cifs: sanity check length of data to send before sending
Date: Tue, 23 Sep 2014 15:09:23 -0400	[thread overview]
Message-ID: <5421C563.8070304@canonical.com> (raw)

Hi Jeff,

A kernel bug report was opened against Ubuntu [0].  It was found that
reverting the following commit resolved this bug:


commit a26054d184763969a411e3939fe243516715ff59
Author: Jeff Layton <jlayton@redhat.com>
Date:   Fri Feb 14 07:21:00 2014 -0500

    cifs: sanity check length of data to send before sending

      
The regression was introduced as of v3.14-rc7.

It appears the patch may be doing what it is supposed to, since the
send_length != smb_buf_length:
send_length=72
and
smb_buf_length=2164260932

However, without this check and WARN/return of -EIO the samba
connections still work correctly.

I was hoping to get your feedback, since you are the patch author.  Do
you think gathering any additional data will help diagnose this issue,
or would it be best to submit a revert request?
    
Thanks,
    
Joe

[0] http://pad.lv/1372482


             reply	other threads:[~2014-09-23 19:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 19:09 Joseph Salisbury [this message]
2014-09-23 22:49 ` [Regression] cifs: sanity check length of data to send before sending Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5421C563.8070304@canonical.com \
    --to=joseph.salisbury@canonical.com \
    --cc=jlayton@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox