From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757097AbaIWXTF (ORCPT ); Tue, 23 Sep 2014 19:19:05 -0400 Received: from lists.s-osg.org ([54.187.51.154]:37326 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292AbaIWXTC (ORCPT ); Tue, 23 Sep 2014 19:19:02 -0400 Message-ID: <5421FFE3.8060402@osg.samsung.com> Date: Tue, 23 Sep 2014 17:18:59 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Eric W. Biederman" CC: akpm@linux-foundation.org, gregkh@linuxfoundation.org, colin.king@canonical.com, dbueso@suse.de, serge.hallyn@ubuntu.com, thierry@linux.vnet.ibm.com, luto@amacapital.net, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v2 5/7] selftests/mount: change test to use ksft framework References: <969f0780734a04763f2b54063603b93380244d0c.1411506121.git.shuahkh@osg.samsung.com> <87d2am2c4v.fsf@x220.int.ebiederm.org> <5421FA8A.9050209@osg.samsung.com> <8761geylzj.fsf@x220.int.ebiederm.org> In-Reply-To: <8761geylzj.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2014 05:07 PM, Eric W. Biederman wrote: > Shuah Khan writes: > >> On 09/23/2014 04:41 PM, Eric W. Biederman wrote: >>> Shuah Khan writes: >>> >>>> Change mount test to use kselftest framework to report >>>> test results. >>> >>> Nacked-by: "Eric W. Biederman" >>> >>> I am curious did you even run these tests? I can't possibly see how >>> the tests would have passed with this change. At the very least you >>> have taken this test from linear to exponential time complexity. >>> >> >> Oops. I meant to drop this commit from the series. Sorry for the >> noise. > > No problem. Except for the unnecessary semantic change the rest of the > change looked fine. I just wanted to make certain you didn't break my > test by accident. > Thanks for catching it. The results didn't look right and I meant to delay this change for later after another round of testing. I will fix it without the unnecessary change and send it out separately. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978