Re: [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead

H. Peter Anvin
2014-09-24T18:42:47Z

On 09/24/2014 09:07 AM, Bryan O'Donoghue wrote:
>>
>> So __flush_tlb_all(); will do nothing but that's OK since load_cr3()
>> already flushed the TLB - including any PTE with PGE set
>
> I take your point though.
>
> It's probably better to be explicit and do the whole
>
> if (quark)
> __flush_tlb();
> else
> __flush_tlb_all();
>
> So that we aren't relying on the side effects of the previous statement.
>

Well, we need a comment at least.

-hpa