From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 09/10] blk-mq: handle failure path for initializing hctx
Date: Wed, 24 Sep 2014 08:17:25 -0600 [thread overview]
Message-ID: <5422D275.8060300@kernel.dk> (raw)
In-Reply-To: <20140924102225.GD19078@lst.de>
On 09/24/2014 04:22 AM, Christoph Hellwig wrote:
> On Mon, Sep 15, 2014 at 09:11:13PM +0800, Ming Lei wrote:
>> Failure of initializing one hctx isn't handled, so this patch
>> introduces blk_mq_init_hctx() and its pair to handle it explicitly.
>> Also this patch makes code cleaner.
>>
>> Signed-off-by: Ming Lei <ming.lei@canonical.com>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Shouldn't this go to Jens as a separate fix for 3.18?
I think so, doesn't look like it's tied into the series at all.
--
Jens Axboe
next prev parent reply other threads:[~2014-09-24 14:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 13:11 [PATCH v4 0/10] block: per-distpatch_queue flush machinery Ming Lei
2014-09-15 13:11 ` [PATCH v4 01/10] blk-mq: allocate flush_rq in blk_mq_init_flush() Ming Lei
2014-09-15 13:11 ` [PATCH v4 02/10] block: introduce blk_init_flush and its pair Ming Lei
2014-09-24 10:18 ` Christoph Hellwig
2014-09-24 14:46 ` Ming Lei
2014-09-15 13:11 ` [PATCH v4 03/10] block: move flush initialization to blk_flush_init Ming Lei
2014-09-15 13:11 ` [PATCH v4 04/10] block: avoid to use q->flush_rq directly Ming Lei
2014-09-15 13:11 ` [PATCH v4 05/10] block: introduce blk_flush_queue to drive flush machinery Ming Lei
2014-09-15 13:11 ` [PATCH v4 06/10] block: remove blk_init_flush() and its pair Ming Lei
2014-09-24 10:20 ` Christoph Hellwig
2014-09-24 14:49 ` Ming Lei
2014-09-24 14:54 ` Christoph Hellwig
2014-09-15 13:11 ` [PATCH v4 07/10] block: flush: avoid to figure out flush queue unnecessarily Ming Lei
2014-09-15 13:11 ` [PATCH v4 08/10] block: introduce 'blk_mq_ctx' parameter to blk_get_flush_queue Ming Lei
2014-09-24 10:21 ` Christoph Hellwig
2014-09-24 14:56 ` Ming Lei
2014-09-15 13:11 ` [PATCH v4 09/10] blk-mq: handle failure path for initializing hctx Ming Lei
2014-09-24 10:22 ` Christoph Hellwig
2014-09-24 14:17 ` Jens Axboe [this message]
2014-09-24 15:01 ` Ming Lei
2014-09-24 15:03 ` Christoph Hellwig
2014-09-15 13:11 ` [PATCH v4 10/10] blk-mq: support per-distpatch_queue flush machinery Ming Lei
2014-09-24 10:26 ` Christoph Hellwig
2014-09-24 15:21 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422D275.8060300@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox