From: Rik van Riel <riel@redhat.com>
To: Hui Zhu <zhuhui@xiaomi.com>,
gregkh@linuxfoundation.org, rientjes@google.com,
vinayakm.list@gmail.com, weijie.yang@samsung.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
teawater@gmail.com
Subject: Re: [PATCH] Fix the issue that lowmemkiller fell into a cycle that try to kill a task
Date: Wed, 24 Sep 2014 11:34:12 -0400 [thread overview]
Message-ID: <5422E474.4010001@redhat.com> (raw)
In-Reply-To: <1411441029-8428-1-git-send-email-zhuhui@xiaomi.com>
On 09/22/2014 10:57 PM, Hui Zhu wrote:
> The cause of this issue is when free memroy size is low and a lot of task is
> trying to shrink the memory, the task that is killed by lowmemkiller cannot get
> CPU to exit itself.
>
> Fix this issue with change the scheduling policy to SCHED_FIFO if a task's flag
> is TIF_MEMDIE in lowmemkiller.
Is it actually true that the task that was killed by lowmemkiller
cannot get CPU time?
It is also possible that the task is busy in the kernel, for example
in the reclaim code, and is not breaking out of some loop fast enough,
despite the TIF_MEMDIE flag being set.
I suspect SCHED_FIFO simply papers over that kind of issue, by not
letting anything else run until the task is gone, instead of fixing
the root cause of the problem.
next prev parent reply other threads:[~2014-09-24 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 2:57 [PATCH] Fix the issue that lowmemkiller fell into a cycle that try to kill a task Hui Zhu
2014-09-23 4:17 ` Greg KH
2014-09-23 4:48 ` 朱辉
2014-09-23 8:00 ` Weijie Yang
2014-09-23 14:28 ` 朱辉
2014-09-23 22:24 ` David Rientjes
2014-09-24 15:34 ` Rik van Riel [this message]
2014-10-14 6:51 ` 朱辉
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422E474.4010001@redhat.com \
--to=riel@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=teawater@gmail.com \
--cc=vinayakm.list@gmail.com \
--cc=weijie.yang@samsung.com \
--cc=zhuhui@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox