From: "H. Peter Anvin" <hpa@zytor.com>
To: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, stable@vger.kernel.org, bp@alien8.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses CR3 instead
Date: Wed, 24 Sep 2014 11:43:47 -0700 [thread overview]
Message-ID: <542310E3.90803@zytor.com> (raw)
In-Reply-To: <54231088.8030000@zytor.com>
On 09/24/2014 11:42 AM, H. Peter Anvin wrote:
> On 09/24/2014 09:07 AM, Bryan O'Donoghue wrote:
>>>
>>> So __flush_tlb_all(); will do nothing but that's OK since load_cr3()
>>> already flushed the TLB - including any PTE with PGE set
>>
>> I take your point though.
>>
>> It's probably better to be explicit and do the whole
>>
>> if (quark)
>> __flush_tlb();
>> else
>> __flush_tlb_all();
>>
>> So that we aren't relying on the side effects of the previous statement.
>>
>
> Well, we need a comment at least.
>
And certainly we don't need an if/else as we can just do it.
-hpa
next prev parent reply other threads:[~2014-09-24 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411514784-14885-1-git-send-email-pure.logic@nexus-software.ie>
[not found] ` <20140924071221.GB990@gmail.com>
2014-09-24 10:15 ` [PATCH] x86: Quark: Switch of CR4.PGE TLB flush use CR3 instead Bryan O'Donoghue
2014-09-24 15:01 ` [tip:x86/platform] x86/intel/quark: Switch off CR4.PGE so TLB flush uses " tip-bot for Bryan O'Donoghue
2014-09-24 15:52 ` H. Peter Anvin
2014-09-24 15:58 ` Bryan O'Donoghue
2014-09-24 16:07 ` Bryan O'Donoghue
2014-09-24 18:42 ` H. Peter Anvin
2014-09-24 18:43 ` H. Peter Anvin [this message]
2014-09-24 20:22 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542310E3.90803@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox