From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
Miao Xie <miaox@cn.fujitsu.com>,
"Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
"David Rientjes" <rientjes@google.com>
Subject: Re: [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant
Date: Thu, 25 Sep 2014 09:42:23 +0800 [thread overview]
Message-ID: <542372FF.4020808@huawei.com> (raw)
In-Reply-To: <20140924133513.GD16555@htj.dyndns.org>
On 2014/9/24 21:35, Tejun Heo wrote:
> On Wed, Sep 24, 2014 at 09:22:18AM -0400, Tejun Heo wrote:
>> On Tue, Sep 23, 2014 at 03:44:19PM +0800, Zefan Li wrote:
>>> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>>>
>>> Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
>>> defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
>>> because it is used as bit number. Redefine it as decimal bit number.
>>>
>>> Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0.
>>>
>>> Cc: Peter Zijlstra <peterz@infradead.org>
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: Miao Xie <miaox@cn.fujitsu.com>
>>> Cc: Kees Cook <keescook@chromium.org>
>>> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>>> Acked-by: Kees Cook <keescook@chromium.org>
>>> [ lizf: slightly modified subject and changelog ]
>>> Signed-off-by: Zefan Li <lizefan@huawei.com>
>>
>> Applied 1-3 to cgroup/for-3.17-fixes w/ the typo spotted by davidr
>> fixed.
>
> Reverted due to build failure. Will wait for a refreshed version. :(
>
Didn't notice mm/slab.c uses PF_SPREAD_SLAB without the cpuset wrapper...
prev parent reply other threads:[~2014-09-25 1:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 7:44 [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant Zefan Li
2014-09-23 7:44 ` [PATCH v3 2/3] sched: add macros to define bitops for task atomic flags Zefan Li
2014-09-23 10:01 ` Peter Zijlstra
2014-09-23 16:58 ` Kees Cook
2014-09-23 7:45 ` [PATCH v3 3/3] cpuset: PF_SPREAD_PAGE and PF_SPREAD_SLAB should be " Zefan Li
2014-09-23 22:10 ` David Rientjes
2014-09-24 3:15 ` Zefan Li
2014-09-24 13:22 ` [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant Tejun Heo
2014-09-24 13:35 ` Tejun Heo
2014-09-24 14:09 ` Tetsuo Handa
2014-09-24 14:32 ` Tejun Heo
2014-09-25 1:42 ` Zefan Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542372FF.4020808@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).