From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755280AbaIZOAf (ORCPT ); Fri, 26 Sep 2014 10:00:35 -0400 Received: from service87.mimecast.com ([91.220.42.44]:42861 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755169AbaIZOAa convert rfc822-to-8bit (ORCPT ); Fri, 26 Sep 2014 10:00:30 -0400 Message-ID: <54257178.8010900@arm.com> Date: Fri, 26 Sep 2014 15:00:24 +0100 From: Dietmar Eggemann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Vincent Guittot CC: "peterz@infradead.org" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "preeti@linux.vnet.ibm.com" , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" , "riel@redhat.com" , Morten Rasmussen , "efault@gmx.de" , "nicolas.pitre@linaro.org" , "linaro-kernel@lists.linaro.org" , "daniel.lezcano@linaro.org" , "pjt@google.com" , "bsegall@google.com" Subject: Re: [PATCH v6 5/6] sched: replace capacity_factor by usage References: <1411488485-10025-1-git-send-email-vincent.guittot@linaro.org> <1411488485-10025-6-git-send-email-vincent.guittot@linaro.org> <542303DF.8010606@arm.com> <54246ACE.1080502@arm.com> In-Reply-To: X-OriginalArrivalTime: 26 Sep 2014 14:00:24.0717 (UTC) FILETIME=[3820F3D0:01CFD992] X-MC-Unique: 114092615002702401 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/09/14 13:39, Vincent Guittot wrote: > On 25 September 2014 21:19, Dietmar Eggemann wrote: >> On 25/09/14 09:35, Vincent Guittot wrote: > > [snip] > >>>> >>>> In case sgs->group_type is group_overloaded you could set >>>> sgs->group_out_of_capacity to 1 without calling group_is_overloaded again. >>> >>> I prefer to keep sgs->group_out_of_capacity = group_is_overloaded(sgs, >>> env) and use it in group_classify in case of future changes in the >>> classification order >> >> Ok, but than group_is_overloaded is called twice at the end of >> update_sg_lb_stats with exactly the same result. Looks weird in my traces. > > sorry i don't catch your point. > group_is_overloaded() is called once for group_out_of_capacity which > is then used in group_classify so it should be called only once You're right, I made a mistake in my local setup while replacing this patch with the new version. Problem doesn't exist any more. > >> >>> >> [...] >> >> >