From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752686AbaI0SVo (ORCPT ); Sat, 27 Sep 2014 14:21:44 -0400 Received: from svenfoo.org ([82.94.215.22]:44983 "EHLO mail.zonque.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbaI0SVm (ORCPT ); Sat, 27 Sep 2014 14:21:42 -0400 Message-ID: <54270032.5010204@zonque.org> Date: Sat, 27 Sep 2014 20:21:38 +0200 From: Daniel Mack User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Matt Ranostay , galak@codeaurora.org, dmitry.torokhov@gmail.com, zonque@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org CC: devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/3] cap11xx: make driver generic for variant support References: <1411622662-16581-1-git-send-email-mranostay@gmail.com> <1411622662-16581-2-git-send-email-mranostay@gmail.com> In-Reply-To: <1411622662-16581-2-git-send-email-mranostay@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/25/2014 07:24 AM, Matt Ranostay wrote: > cap1106 driver can support much more one device make the driver > generic for support of similiar parts. > > Signed-off-by: Matt Ranostay > --- > .../devicetree/bindings/input/cap1106.txt | 53 ---- > .../devicetree/bindings/input/cap11xx.txt | 54 ++++ > drivers/input/keyboard/Kconfig | 8 +- > drivers/input/keyboard/Makefile | 2 +- > drivers/input/keyboard/cap1106.c | 341 --------------------- > drivers/input/keyboard/cap11xx.c | 340 ++++++++++++++++++++ > 6 files changed, 399 insertions(+), 399 deletions(-) As I've said, such a patch is really a whole lot more readable if you use the -M switch for git format-patch to detect renames. Other than that, the series now looks good to me. I can't test it, however, as I don't have access to the hardware anymore. Reviewed-by: Daniel Mack Thanks, Daniel