From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: Pablo Pellecchia <pablo9891@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] scripts/checkpatch.pl - don't check for const structs if list is empty
Date: Tue, 03 Sep 2019 06:38:23 -0400 [thread overview]
Message-ID: <542749.1567507103@turing-police> (raw)
If the list of structures we expect to be const is empty (due to file permissions,
or the file being empty, etc), we get odd complaints about structures:
[/usr/src/linux-next] scripts/checkpatch.pl -f drivers/staging/netlogic/platform_net.h
No structs that should be const will be found - file '/usr/src/linux-next/scripts/const_structs.checkpatch': Permission denied
WARNING: struct should normally be const
#9: FILE: drivers/staging/netlogic/platform_net.h:9:
+struct xlr_net_data {
WARNING: struct should normally be const
#20: FILE: drivers/staging/netlogic/platform_net.h:20:
+ struct xlr_fmn_info *gmac_fmn_info;
total: 0 errors, 2 warnings, 0 checks, 21 lines checked
Fix it so that it actually *obeys* what it said about not finding structures.
Reported-by: Pablo Pellecchia <pablo9891@gmail.com>
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f4b6127ff469..103c67665f61 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6497,7 +6497,7 @@ sub process {
# check for various structs that are normally const (ops, kgdb, device_tree)
# and avoid what seem like struct definitions 'struct foo {'
- if ($line !~ /\bconst\b/ &&
+ if ($line !~ /\bconst\b/ && $const_structs ne "" &&
$line =~ /\bstruct\s+($const_structs)\b(?!\s*\{)/) {
WARN("CONST_STRUCT",
"struct $1 should normally be const\n" . $herecurr);
next reply other threads:[~2019-09-03 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 10:38 Valdis Klētnieks [this message]
2019-09-03 16:05 ` [PATCH] scripts/checkpatch.pl - don't check for const structs if list is empty Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542749.1567507103@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pablo9891@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox