From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750978AbaI1EH7 (ORCPT ); Sun, 28 Sep 2014 00:07:59 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:33697 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbaI1EH6 (ORCPT ); Sun, 28 Sep 2014 00:07:58 -0400 Message-ID: <5427899B.4050205@gmail.com> Date: Sun, 28 Sep 2014 00:07:55 -0400 From: nick User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Randy Dunlap , linux@arm.linux.org.uk CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume References: <1411872652-16207-1-git-send-email-yocto6@gmail.com> <5427810F.2000305@infradead.org> In-Reply-To: <5427810F.2000305@infradead.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-09-27 11:31 PM, Randy Dunlap wrote: > On 09/27/14 19:50, Nicholas Krause wrote: >> This removes the FIXME message and issue with reading in this driver before resuming >> in the function, sa1111_resume. > > You need to explain why this makes any sense. > Hint: it doesn't. > >> Signed-off-by: Nicholas Krause >> --- >> arch/arm/common/sa1111.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c >> index e57d7e5..0c4b9a9 100644 >> --- a/arch/arm/common/sa1111.c >> +++ b/arch/arm/common/sa1111.c >> @@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev) >> >> /* >> * Ensure that the SA1111 is still here. >> - * FIXME: shouldn't do this here. >> */ >> - id = sa1111_readl(sachip->base + SA1111_SKID); >> if ((id & SKID_ID_MASK) != SKID_SA1111_ID) { >> __sa1111_remove(sachip); >> platform_set_drvdata(dev, NULL); >> > > Thanks for the reply Randy. I was wondering if was what the FIX ME meant if it meant something else please let me known. Sorry, Nick