From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbaI1LFd (ORCPT ); Sun, 28 Sep 2014 07:05:33 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:52362 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbaI1LFb (ORCPT ); Sun, 28 Sep 2014 07:05:31 -0400 X-Greylist: delayed 36655 seconds by postgrey-1.27 at vger.kernel.org; Sun, 28 Sep 2014 07:05:30 EDT X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: xjq@rock-chips.com X-FST-TO: cf@rock-chips.com X-SENDER-IP: 127.0.0.1 X-LOGIN-NAME: xjq@rock-chips.com X-UNIQUE-TAG: <4345c13a690f52df0ae9a7e1db0848be> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 1 Message-ID: <5427EB66.5090607@rock-chips.com> Date: Sun, 28 Sep 2014 19:05:10 +0800 From: Jianqun User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Mark Brown CC: Jianqun , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, grant.likely@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, huangtao@rock-chips.com, cf@rock-chips.com Subject: Re: [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver References: <1410506806-15327-1-git-send-email-jay.xu@rock-chips.com> <1410507036-15442-1-git-send-email-jay.xu@rock-chips.com> <20140912134446.GT7960@sirena.org.uk> <54275C43.8010205@rock-chips.com> <20140928104851.GR27755@sirena.org.uk> In-Reply-To: <20140928104851.GR27755@sirena.org.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 09/28/2014 06:48 PM, Mark Brown 写道: > On Sun, Sep 28, 2014 at 08:54:27AM +0800, Jianqun wrote: > > Please fix your mailer to word wrap within paragraphs. > >> 在 09/12/2014 09:44 PM, Mark Brown 写道: >>> On Fri, Sep 12, 2014 at 03:30:36PM +0800, Jianqun wrote: >>>> Add documentation for rockchip-max98090 driver, which is need by rockchip >>>> board using a max98090. > >>> Can this use simple-card (perhaps after a bit of extension)? >> I haven't ever try simple-card, is there any sample usage for me from other vendor ? > > $ git grep -l simple-audio-card > Documentation/devicetree/bindings/sound/simple-card.txt > arch/arm/boot/dts/kirkwood-openrd-client.dts > arch/arm/boot/dts/kirkwood-t5325.dts > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > arch/arm/boot/dts/sh73a0-kzm9g-reference.dts > arch/arm/boot/dts/vf610-twr.dts > sound/soc/generic/simple-card.c > thanks >>>> +- rockchip,audio-codec : The phandle of the MAX98090 audio codec. > >>> Is the driver really specific to this CODEC? > >> I think yes, we need to add two gpio for mic and hp detect, but simple-card driver hasn't them > > That'd be the "possibly with some extensions" bit then... if they're > just isolated GPIOs there's not really much board specific about having > them. > I'll try it first, thanks Mark -- Jianqun Xu **************************************************************************** *IMPORTANT NOTICE:*This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material in its entirety in any format. Thank you. ****************************************************************************