From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753646AbaI2Mew (ORCPT ); Mon, 29 Sep 2014 08:34:52 -0400 Received: from smtp73.ord1c.emailsrvr.com ([108.166.43.73]:50215 "EHLO smtp73.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753453AbaI2Meu (ORCPT ); Mon, 29 Sep 2014 08:34:50 -0400 X-Sender-Id: kiran.padwal@smartplayin.com Message-ID: <54295165.4030201@smartplayin.com> Date: Mon, 29 Sep 2014 18:02:37 +0530 From: Kiran Padwal User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: Richard Weinberger CC: Kiran Padwal , Tanya Brokhman , dedeking1@gmail.com, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, Artem Bityutskiy , David Woodhouse , Brian Norris , open list Subject: Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities References: <1411886185-7838-1-git-send-email-tlinder@codeaurora.org> <54293975.9040402@gmail.com> <54294A01.8070505@nod.at> In-Reply-To: <54294A01.8070505@nod.at> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 29 September 2014 05:31 PM, Richard Weinberger wrote: > Am 29.09.2014 12:50, schrieb Kiran Padwal: >> Hi Tanya, >> >> On Sunday 28 September 2014 12:06 PM, Tanya Brokhman wrote: >>> If there is more then one UBI device mounted, there is no way to >>> distinguish between messages from different UBI devices. >>> Add device number to all ubi layer message types. >>> >>> >>> Signed-off-by: Tanya Brokhman >>> >>> --- >>> drivers/mtd/ubi/attach.c | 138 ++++++++++++++++++++---------------- >>> drivers/mtd/ubi/build.c | 130 ++++++++++++++++++++-------------- >>> drivers/mtd/ubi/cdev.c | 37 +++++----- >>> drivers/mtd/ubi/debug.c | 9 +-- >>> drivers/mtd/ubi/eba.c | 54 +++++++------- >>> drivers/mtd/ubi/fastmap.c | 108 ++++++++++++++++------------ >>> drivers/mtd/ubi/io.c | 177 +++++++++++++++++++++++++++------------------- >>> drivers/mtd/ubi/kapi.c | 6 +- >>> drivers/mtd/ubi/misc.c | 6 +- >>> drivers/mtd/ubi/ubi.h | 13 ++-- >>> drivers/mtd/ubi/vmt.c | 76 +++++++++++--------- >>> drivers/mtd/ubi/vtbl.c | 54 ++++++++------ >>> drivers/mtd/ubi/wl.c | 87 +++++++++++++++-------- >>> 13 files changed, 521 insertions(+), 374 deletions(-) >> >> Compilation breaks while I try to compile with this patch. >> May be you need to update remaining ubi layer messages also. > > Please always share the errors you face. > Maybe you have a different config. Sure, I will take care of this next time. Macros have been changed but some instances of older macros still remained, which caused many errors like, drivers/mtd/ubi/build.c: In function ‘ubi_init’: drivers/mtd/ubi/build.c:1322:49: error: expected ‘)’ before ‘err’ ubi_err("block: cannot initialize, error %d", err); ^ > > Thanks, > //richard > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >