From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<sgruszka@redhat.com>, <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>, <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] Revert "xen/acpi-processor: fix enabling interrupts on syscore_resume"
Date: Mon, 29 Sep 2014 15:56:14 +0100 [thread overview]
Message-ID: <5429730E.1050506@citrix.com> (raw)
In-Reply-To: <1412002276-30873-1-git-send-email-konrad.wilk@oracle.com>
On 29/09/14 15:51, Konrad Rzeszutek Wilk wrote:
> This reverts commit cd979883b9ede90643e019f33cb317933eb867b4.
>
> As it actually never gets called on the initial domain when
> resuming. That is after we suspend and go in resume, the
> do_suspend (from manage.c) is never called (it is if it
> was running as a guest)- so the 'resume' functionality of the driver
> was never called.
>
> Which means that this whole patch was pointless (well, it did
> remove the WARNING splat).
>
> This patch reverts the patch and allows the C and P states to
> be uploaded to the hypervisor on ACPI S3 resume of the
> initial domain. It sadly brings back the WARNING splat which
> will have to be dealt with at some point.
Incorrectly enabling interrupts in contexts where this is not permitted
is not just harmless "WARNING splat".
This has been broken since 3.15-rc1 without anyone else noticing so I
think we can afford to take a bit more time and fix the original bug
properly.
David
next prev parent reply other threads:[~2014-09-29 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 14:51 [PATCH] Revert "xen/acpi-processor: fix enabling interrupts on syscore_resume" Konrad Rzeszutek Wilk
2014-09-29 14:56 ` David Vrabel [this message]
2014-09-29 15:07 ` Konrad Rzeszutek Wilk
2014-09-29 16:46 ` David Vrabel
2014-09-29 17:55 ` Konrad Rzeszutek Wilk
2014-09-29 18:06 ` David Vrabel
2014-09-30 12:08 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5429730E.1050506@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox