* [PATCH v2 1/3] ASoC: ssm2602: do not hardcode type to SSM2602
@ 2014-09-29 19:39 Stefan Kristiansson
2014-09-29 19:51 ` Lars-Peter Clausen
2014-09-30 12:38 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Kristiansson @ 2014-09-29 19:39 UTC (permalink / raw)
To: linux-kernel; +Cc: alsa-devel, lgirdwood, broonie, lars, Stefan Kristiansson
The correct type (SSM2602/SSM2603/SSM2604) is passed down
from the ssm2602_spi_probe()/ssm2602_spi_probe() functions,
so use that instead of hardcoding it to SSM2602 in
ssm2602_probe().
Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
---
Changes in v2:
- None, new in series.
---
sound/soc/codecs/ssm2602.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c
index 484b3bb..4021cd4 100644
--- a/sound/soc/codecs/ssm2602.c
+++ b/sound/soc/codecs/ssm2602.c
@@ -647,7 +647,7 @@ int ssm2602_probe(struct device *dev, enum ssm2602_type type,
return -ENOMEM;
dev_set_drvdata(dev, ssm2602);
- ssm2602->type = SSM2602;
+ ssm2602->type = type;
ssm2602->regmap = regmap;
return snd_soc_register_codec(dev, &soc_codec_dev_ssm2602,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/3] ASoC: ssm2602: do not hardcode type to SSM2602
2014-09-29 19:39 [PATCH v2 1/3] ASoC: ssm2602: do not hardcode type to SSM2602 Stefan Kristiansson
@ 2014-09-29 19:51 ` Lars-Peter Clausen
2014-09-30 12:38 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2014-09-29 19:51 UTC (permalink / raw)
To: Stefan Kristiansson, linux-kernel; +Cc: alsa-devel, lgirdwood, broonie
On 09/29/2014 09:39 PM, Stefan Kristiansson wrote:
> The correct type (SSM2602/SSM2603/SSM2604) is passed down
> from the ssm2602_spi_probe()/ssm2602_spi_probe() functions,
> so use that instead of hardcoding it to SSM2602 in
> ssm2602_probe().
>
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Fixes: c924dc68f737 ("ASoC: ssm2602: Split SPI and I2C code into different \
modules")
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/3] ASoC: ssm2602: do not hardcode type to SSM2602
2014-09-29 19:39 [PATCH v2 1/3] ASoC: ssm2602: do not hardcode type to SSM2602 Stefan Kristiansson
2014-09-29 19:51 ` Lars-Peter Clausen
@ 2014-09-30 12:38 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-09-30 12:38 UTC (permalink / raw)
To: Stefan Kristiansson; +Cc: linux-kernel, alsa-devel, lgirdwood, lars
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
On Mon, Sep 29, 2014 at 10:39:13PM +0300, Stefan Kristiansson wrote:
> The correct type (SSM2602/SSM2603/SSM2604) is passed down
> from the ssm2602_spi_probe()/ssm2602_spi_probe() functions,
> so use that instead of hardcoding it to SSM2602 in
> ssm2602_probe().
Applied all, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-30 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-29 19:39 [PATCH v2 1/3] ASoC: ssm2602: do not hardcode type to SSM2602 Stefan Kristiansson
2014-09-29 19:51 ` Lars-Peter Clausen
2014-09-30 12:38 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox