From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755495AbaI3ItK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 30 Sep 2014 04:49:10 -0400
Received: from smtp97.ord1c.emailsrvr.com ([108.166.43.97]:52687 "EHLO
	smtp97.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751922AbaI3ItH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 30 Sep 2014 04:49:07 -0400
X-Sender-Id: kiran.padwal@smartplayin.com
Message-ID: <542A6DFD.7020107@smartplayin.com>
Date: Tue, 30 Sep 2014 14:16:53 +0530
From: Kiran Padwal <kiran.padwal@smartplayin.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8
MIME-Version: 1.0
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
CC: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Grant Likely <grant.likely@linaro.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, David Collins <collinsd@codeaurora.org>
Subject: Re: [PATCH v2] thermal: Add QPNP PMIC temperature alarm driver
References: <1411651825-14240-1-git-send-email-iivanov@mm-sol.com>   <54254C4E.3070807@smartplayin.com> <1411998865.5395.5.camel@iivanov-dev>  <542A31DF.7020402@smartplayin.com> <1412062606.5395.10.camel@iivanov-dev>
In-Reply-To: <1412062606.5395.10.camel@iivanov-dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 30 September 2014 01:06 PM, Ivan T. Ivanov wrote:
> On Tue, 2014-09-30 at 10:00 +0530, Kiran Padwal wrote:
>> On Monday 29 September 2014 07:24 PM, Ivan T. Ivanov wrote:
>>> On Fri, 2014-09-26 at 16:51 +0530, Kiran Padwal wrote:
>>>> On Thursday 25 September 2014 07:00 PM, Ivan T. Ivanov wrote:
>>>>> Add support for the temperature alarm peripheral found inside
>>>>> Qualcomm plug-and-play (QPNP) PMIC chips.  The temperature alarm
>>>>> peripheral outputs a pulse on an interrupt line whenever the
>>>>> thermal over temperature stage value changes.  Implement an ISR
>>>>> to manage this interrupt.
>>>>>
>>>>
>>>> <snip>
>>>>
>>>>> + * This function updates the internal temp value based on the
>>>>> + * current thermal stage and threshold as well as the previous stage
>>>>> + */
>>>>> +static int qpnp_tm_update_temp_no_adc(struct qpnp_tm_chip *chip)
>>>>> +{
>>>>> +	unsigned int stage;
>>>>> +	int rc;
>>>>> +	u8 reg;
>>>>> +
>>>>> +	rc = qpnp_tm_read(chip, QPNP_TM_REG_STATUS, &reg);
>>>>> +	if (rc < 0)
>>>>> +		return rc;
>>>>> +
>>>>> +	stage = reg & STATUS_STAGE_MASK;
>>>>
>>>> During compilation, getting a waring as below,
>>>>
>>>> drivers/thermal/qpnp-temp-alarm.c: In function ‘qpnp_tm_update_temp_no_adc’:
>>>> drivers/thermal/qpnp-temp-alarm.c:135:8: warning: ‘reg’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>   stage = reg & STATUS_STAGE_MASK;
>>>
>>> Could you share compiler version and options which you are using.
>>> I am unable to trigger this warning. Looking code I can not 
>>> see how this could happen.
>>
>> I have Linaro cross tool chain with version-4.8.3 and I am simply doing "make zImage" without any option.
> 
> Hm, no warnings with arm-unknown-linux-gnueabi-gcc (GCC) 4.6.3 and
> arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-4.9-2014.09, but
> indeed arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-4.8-2014.03.
> 
> I will say that this is false positive :-). Please update your tool-chain.
> 

Thanks to verify, I will do that.

Thanks,
--Kiran