Re: [PATCH v2] thermal: Add QPNP PMIC temperature alarm driver

Stephen Boyd
2014-09-30T19:46:24Z

On 09/30/14 00:36, Ivan T. Ivanov wrote:
> On Tue, 2014-09-30 at 10:00 +0530, Kiran Padwal wrote:
>>
>> I have Linaro cross tool chain with version-4.8.3 and I am simply doing "make zImage" without any option.
> Hm, no warnings with arm-unknown-linux-gnueabi-gcc (GCC) 4.6.3 and
> arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-4.9-2014.09, but
> indeed arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-4.8-2014.03.
>
> I will say that this is false positive :-). Please update your tool-chain.

Hopefully you're joking. Once this merges someone will find the warning
and complain. Telling them to upgrade their compiler isn't going to work.

I wonder if checking for rc != 0 instead of rc < 0 would silence the
warning? Or get rid of the entire wrapper function and just use regmap
functions directly.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation