Re: [PATCH] regmap: Allow read_reg_mask to be 0

Mark Brown
2014-10-01T11:15:18Z

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

On Tue, Sep 30, 2014 at 11:29:34PM +0200, Lars-Peter Clausen wrote:
> On 09/30/2014 11:18 PM, Dan Murphy wrote:

Dan, please fix your mail client to word wrap within paragraphs.

> >The device, which is already in production, has a specific control register that sets either the reading or writing of the rest of the registers.

> >Here is the data sheet

> >http://www.ti.com/lit/ds/symlink/afe4403.pdf

> >See page 61 control0.

> >Driver is written for this part just want to get this lead patch in or maybe an alternate solution.

> Looking at this the generic SPI regmap implementation might not necessarily
> be the best thing to use here and you are probably better of implementing
> either your own regmap bus or reg_read/reg_write callbacks that
> automatically set/clear the SPI_READ bit in the control register depending
> on the operation.

It definitely needs more than just this change at any rate - any generic
infrastructure that tries to work with the regmap is not going to know
about this read/write register.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]