Re: [PATCH] MM: dmapool: Fixed a brace coding style issue

Andy Shevchenko
2014-10-01T11:31:39Z

On Tue, 2014-09-30 at 21:49 +0100, Paul McQuade wrote:
> From 33890970bfffc2bd64b307c41e5c1c92aaba8a2e Mon Sep 17 00:00:00 2001
> From: Paul McQuade <paulmcquad@gmail.com>
> Date: Tue, 30 Sep 2014 21:39:37 +0100
> Subject: [PATCH] MM: dmapool: Fixed a brace coding style issue
>
> Removed 3 brace coding style for any arm of this statement
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
> mm/dmapool.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/mm/dmapool.c b/mm/dmapool.c
> index ba8019b..8b3b050 100644
> --- a/mm/dmapool.c
> +++ b/mm/dmapool.c
> @@ -133,28 +133,27 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
> struct dma_pool *retval;
> size_t allocation;
>
> - if (align == 0) {
> + if (align == 0)
> align = 1;
> - } else if (align & (align - 1)) {
> + else if (align & (align - 1))
> return NULL;
> - }
>
> - if (size == 0) {
> +

Extra empty line?

> + if (size == 0)
> return NULL;
> - } else if (size < 4) {
> + else if (size < 4)

> size = 4;
> - }
> +
>
> if ((size % align) != 0)
> size = ALIGN(size, align);
>
> allocation = max_t(size_t, size, PAGE_SIZE);
>
> - if (!boundary) {
> + if (!boundary)
> boundary = allocation;
> - } else if ((boundary < size) || (boundary & (boundary - 1))) {
> + else if ((boundary < size) || (boundary & (boundary - 1)))
> return NULL;
> - }
>
> retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev));
> if (!retval)

--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy