From: Timur Tabi <timur@tabi.org>
To: Scott Wood <scottwood@freescale.com>
Cc: "J. German Rivera" <German.Rivera@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
lkml <linux-kernel@vger.kernel.org>,
stuart.yoder@freescale.com,
Kim Phillips <Kim.Phillips@freescale.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH 3/3 v2] drivers/bus: Device driver for FSL-MC DPRC devices
Date: Tue, 30 Sep 2014 21:35:46 -0500 [thread overview]
Message-ID: <542B6882.9060801@tabi.org> (raw)
In-Reply-To: <1412130432.13320.342.camel@snotra.buserror.net>
Scott Wood wrote:
>>> > >+ if (num_child_objects_in_mc != 0) {
>> >
>> >Like here. Just do "if (num_child_objects_in_mc) {"
> This seems to be a place that is testing for zero as a value rather than
> as a stand-in for NULL, so I'd argue it's better style to leave it as
> is.
But in this case, zero means "none left", so this is a perfectly valid
use-case for omitting the !=.
strcmp() is the only time I can think of to put an explicit != 0,
because this:
if (!strcmp(s1, s2))
is counter-intuitive.
next prev parent reply other threads:[~2014-10-01 2:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 22:49 [PATCH 0/3 v2] drivers/bus: Freescale Management Complex bus driver patch series J. German Rivera
2014-09-19 22:49 ` [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs J. German Rivera
2014-09-24 0:49 ` Kim Phillips
2014-09-25 2:23 ` German Rivera
2014-09-25 3:40 ` Kim Phillips
2014-09-25 15:44 ` German Rivera
2014-09-25 16:16 ` Scott Wood
2014-09-25 16:44 ` German Rivera
2014-09-25 20:05 ` Scott Wood
2014-09-19 22:49 ` [PATCH 2/3 v2] drivers/bus: Freescale Management Complex (fsl-mc) bus driver J. German Rivera
2014-09-19 22:49 ` [PATCH 3/3 v2] drivers/bus: Device driver for FSL-MC DPRC devices J. German Rivera
2014-10-01 2:19 ` Timur Tabi
2014-10-01 2:27 ` Scott Wood
2014-10-01 2:35 ` Timur Tabi [this message]
2014-10-02 16:36 ` German Rivera
2014-10-02 17:19 ` Timur Tabi
2014-09-22 16:53 ` [PATCH 0/3 v2] drivers/bus: Freescale Management Complex bus driver patch series Kim Phillips
2014-09-22 17:59 ` Stuart Yoder
2014-09-22 22:03 ` Kim Phillips
2014-09-23 14:52 ` German Rivera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542B6882.9060801@tabi.org \
--to=timur@tabi.org \
--cc=German.Rivera@freescale.com \
--cc=Kim.Phillips@freescale.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox