From: Sasha Levin <sasha.levin@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Cong Wang <cwang@twopensource.com>,
Vince Weaver <vincent.weaver@maine.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: perf: perf_fuzzer triggers instant reboot
Date: Wed, 01 Oct 2014 07:16:11 -0400 [thread overview]
Message-ID: <542BE27B.6040006@oracle.com> (raw)
In-Reply-To: <20140930172308.GI4241@worktop.programming.kicks-ass.net>
On 09/30/2014 01:23 PM, Peter Zijlstra wrote:
> How about this then?
>
> ---
> Subject: perf: Fix unclone_ctx() vs locking
>
> The idiot who did 4a1c0f262f88 forgot to pay attention and fix all
> similar cases. Do so now.
>
> In particular, unclone_ctx() must be called while holding ctx->lock,
> therefore all such sites are broken for the same reason. Pull the
> put_ctx() call out from under ctx->lock.
>
> Reported-by: Sasha Levin <sasha.levin@oracle.com>
> Fixes: 4a1c0f262f88 ("perf: Fix lockdep warning on process exit")
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Looks good! The issue didn't reproduce anymore.
Thanks,
Sasha
next prev parent reply other threads:[~2014-10-01 11:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 17:47 perf: perf_fuzzer triggers instant reboot Vince Weaver
2014-09-08 18:51 ` Peter Zijlstra
2014-09-08 19:08 ` Vince Weaver
2014-09-09 16:06 ` Vince Weaver
2014-09-09 17:20 ` Vince Weaver
2014-09-09 17:53 ` Vince Weaver
2014-09-10 8:31 ` Peter Zijlstra
2014-09-10 13:18 ` Vince Weaver
2014-09-10 13:28 ` Peter Zijlstra
2014-09-10 14:01 ` Sasha Levin
2014-09-10 14:30 ` Vince Weaver
2014-09-10 14:33 ` Peter Zijlstra
2014-09-11 13:27 ` Vince Weaver
2014-09-25 4:59 ` Vince Weaver
2014-09-25 16:38 ` Cong Wang
2014-09-28 4:09 ` Sasha Levin
2014-09-29 11:11 ` Peter Zijlstra
2014-09-29 17:01 ` Sasha Levin
2014-09-30 8:54 ` Peter Zijlstra
2014-09-30 17:23 ` Peter Zijlstra
2014-10-01 11:16 ` Sasha Levin [this message]
2014-10-02 15:06 ` Vince Weaver
2014-10-02 16:06 ` Vince Weaver
2014-10-03 5:27 ` [tip:perf/urgent] perf: Fix unclone_ctx() vs. locking tip-bot for Peter Zijlstra
2014-09-29 5:21 ` perf: perf_fuzzer triggers instant reboot Vince Weaver
2014-09-30 17:58 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542BE27B.6040006@oracle.com \
--to=sasha.levin@oracle.com \
--cc=acme@kernel.org \
--cc=cwang@twopensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).