* [PATCH] block: hd: remove deprecated IRQF_DISABLED
@ 2013-10-12 4:29 Michael Opdenacker
2013-12-09 9:17 ` [PATCH][RESEND] " Michael Opdenacker
0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2013-10-12 4:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Michael Opdenacker
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
This also removes a related comment which is obsolete too.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
drivers/block/hd.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/block/hd.c b/drivers/block/hd.c
index bf397bf..e16985f 100644
--- a/drivers/block/hd.c
+++ b/drivers/block/hd.c
@@ -694,16 +694,6 @@ static const struct block_device_operations hd_fops = {
.getgeo = hd_getgeo,
};
-/*
- * This is the hard disk IRQ description. The IRQF_DISABLED in sa_flags
- * means we run the IRQ-handler with interrupts disabled: this is bad for
- * interrupt latency, but anything else has led to problems on some
- * machines.
- *
- * We enable interrupts in some of the routines after making sure it's
- * safe.
- */
-
static int __init hd_init(void)
{
int drive;
@@ -761,7 +751,7 @@ static int __init hd_init(void)
p->cyl, p->head, p->sect);
}
- if (request_irq(HD_IRQ, hd_interrupt, IRQF_DISABLED, "hd", NULL)) {
+ if (request_irq(HD_IRQ, hd_interrupt, 0, "hd", NULL)) {
printk("hd: unable to get IRQ%d for the hard disk driver\n",
HD_IRQ);
goto out1;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH][RESEND] block: hd: remove deprecated IRQF_DISABLED
2013-10-12 4:29 [PATCH] block: hd: remove deprecated IRQF_DISABLED Michael Opdenacker
@ 2013-12-09 9:17 ` Michael Opdenacker
2014-03-04 21:20 ` [PATCH] [RESEND] " Michael Opdenacker
0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2013-12-09 9:17 UTC (permalink / raw)
To: linux-kernel; +Cc: Michael Opdenacker
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
This also removes a related comment which is obsolete too.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
drivers/block/hd.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/block/hd.c b/drivers/block/hd.c
index bf397bf108b7..e16985fc5639 100644
--- a/drivers/block/hd.c
+++ b/drivers/block/hd.c
@@ -694,16 +694,6 @@ static const struct block_device_operations hd_fops = {
.getgeo = hd_getgeo,
};
-/*
- * This is the hard disk IRQ description. The IRQF_DISABLED in sa_flags
- * means we run the IRQ-handler with interrupts disabled: this is bad for
- * interrupt latency, but anything else has led to problems on some
- * machines.
- *
- * We enable interrupts in some of the routines after making sure it's
- * safe.
- */
-
static int __init hd_init(void)
{
int drive;
@@ -761,7 +751,7 @@ static int __init hd_init(void)
p->cyl, p->head, p->sect);
}
- if (request_irq(HD_IRQ, hd_interrupt, IRQF_DISABLED, "hd", NULL)) {
+ if (request_irq(HD_IRQ, hd_interrupt, 0, "hd", NULL)) {
printk("hd: unable to get IRQ%d for the hard disk driver\n",
HD_IRQ);
goto out1;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] [RESEND] block: hd: remove deprecated IRQF_DISABLED
2013-12-09 9:17 ` [PATCH][RESEND] " Michael Opdenacker
@ 2014-03-04 21:20 ` Michael Opdenacker
2014-03-18 8:03 ` Michael Opdenacker
0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2014-03-04 21:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag
from drivers/block/hd.c
It's a NOOP since 2.6.35 and it will be removed one day.
This also removes a related comment which is obsolete too.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
drivers/block/hd.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/block/hd.c b/drivers/block/hd.c
index bf397bf108b7..e16985fc5639 100644
--- a/drivers/block/hd.c
+++ b/drivers/block/hd.c
@@ -694,16 +694,6 @@ static const struct block_device_operations hd_fops = {
.getgeo = hd_getgeo,
};
-/*
- * This is the hard disk IRQ description. The IRQF_DISABLED in sa_flags
- * means we run the IRQ-handler with interrupts disabled: this is bad for
- * interrupt latency, but anything else has led to problems on some
- * machines.
- *
- * We enable interrupts in some of the routines after making sure it's
- * safe.
- */
-
static int __init hd_init(void)
{
int drive;
@@ -761,7 +751,7 @@ static int __init hd_init(void)
p->cyl, p->head, p->sect);
}
- if (request_irq(HD_IRQ, hd_interrupt, IRQF_DISABLED, "hd", NULL)) {
+ if (request_irq(HD_IRQ, hd_interrupt, 0, "hd", NULL)) {
printk("hd: unable to get IRQ%d for the hard disk driver\n",
HD_IRQ);
goto out1;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] [RESEND] block: hd: remove deprecated IRQF_DISABLED
2014-03-04 21:20 ` [PATCH] [RESEND] " Michael Opdenacker
@ 2014-03-18 8:03 ` Michael Opdenacker
2014-10-01 10:07 ` Michael Opdenacker
0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2014-03-18 8:03 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag
from drivers/block/hd.c
It's a NOOP since 2.6.35 and it will be removed one day.
This also removes a related comment which is obsolete too.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
drivers/block/hd.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/block/hd.c b/drivers/block/hd.c
index bf397bf108b7..e16985fc5639 100644
--- a/drivers/block/hd.c
+++ b/drivers/block/hd.c
@@ -694,16 +694,6 @@ static const struct block_device_operations hd_fops = {
.getgeo = hd_getgeo,
};
-/*
- * This is the hard disk IRQ description. The IRQF_DISABLED in sa_flags
- * means we run the IRQ-handler with interrupts disabled: this is bad for
- * interrupt latency, but anything else has led to problems on some
- * machines.
- *
- * We enable interrupts in some of the routines after making sure it's
- * safe.
- */
-
static int __init hd_init(void)
{
int drive;
@@ -761,7 +751,7 @@ static int __init hd_init(void)
p->cyl, p->head, p->sect);
}
- if (request_irq(HD_IRQ, hd_interrupt, IRQF_DISABLED, "hd", NULL)) {
+ if (request_irq(HD_IRQ, hd_interrupt, 0, "hd", NULL)) {
printk("hd: unable to get IRQ%d for the hard disk driver\n",
HD_IRQ);
goto out1;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] [RESEND] block: hd: remove deprecated IRQF_DISABLED
2014-03-18 8:03 ` Michael Opdenacker
@ 2014-10-01 10:07 ` Michael Opdenacker
2014-10-01 14:16 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2014-10-01 10:07 UTC (permalink / raw)
To: axboe, akpm; +Cc: linux-kernel, Michael Opdenacker
This patch removes the use of the IRQF_DISABLED flag
from drivers/block/hd.c
It's a NOOP since 2.6.35 and it will be removed one day.
This also removes a related comment which is obsolete too.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
drivers/block/hd.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/block/hd.c b/drivers/block/hd.c
index 8a290c08262f..3abb121825bc 100644
--- a/drivers/block/hd.c
+++ b/drivers/block/hd.c
@@ -694,16 +694,6 @@ static const struct block_device_operations hd_fops = {
.getgeo = hd_getgeo,
};
-/*
- * This is the hard disk IRQ description. The IRQF_DISABLED in sa_flags
- * means we run the IRQ-handler with interrupts disabled: this is bad for
- * interrupt latency, but anything else has led to problems on some
- * machines.
- *
- * We enable interrupts in some of the routines after making sure it's
- * safe.
- */
-
static int __init hd_init(void)
{
int drive;
@@ -761,7 +751,7 @@ static int __init hd_init(void)
p->cyl, p->head, p->sect);
}
- if (request_irq(HD_IRQ, hd_interrupt, IRQF_DISABLED, "hd", NULL)) {
+ if (request_irq(HD_IRQ, hd_interrupt, 0, "hd", NULL)) {
printk("hd: unable to get IRQ%d for the hard disk driver\n",
HD_IRQ);
goto out1;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] [RESEND] block: hd: remove deprecated IRQF_DISABLED
2014-10-01 10:07 ` Michael Opdenacker
@ 2014-10-01 14:16 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2014-10-01 14:16 UTC (permalink / raw)
To: Michael Opdenacker, akpm; +Cc: linux-kernel
On 2014-10-01 04:07, Michael Opdenacker wrote:
> This patch removes the use of the IRQF_DISABLED flag
> from drivers/block/hd.c
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> This also removes a related comment which is obsolete too.
Thanks, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-01 14:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-12 4:29 [PATCH] block: hd: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-12-09 9:17 ` [PATCH][RESEND] " Michael Opdenacker
2014-03-04 21:20 ` [PATCH] [RESEND] " Michael Opdenacker
2014-03-18 8:03 ` Michael Opdenacker
2014-10-01 10:07 ` Michael Opdenacker
2014-10-01 14:16 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox