From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753258AbaJBNfI (ORCPT ); Thu, 2 Oct 2014 09:35:08 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:54219 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbaJBNfG (ORCPT ); Thu, 2 Oct 2014 09:35:06 -0400 Message-ID: <542D55E1.2090309@gmail.com> Date: Thu, 02 Oct 2014 21:40:49 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: daniel.lezcano@linaro.org, tglx@linutronix.de CC: "linux-kernel@vger.kernel.org" , "richard@nod.at >> Richard Weinberger" Subject: Re: [PATCH] drivers/clocksource/Kconfig: Let SH_TIMER_CMT depend on HAS_IOMEM References: <542D546C.8030205@gmail.com> In-Reply-To: <542D546C.8030205@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, it also contents another items which need HAS_IOMEM in this config file, this patch is incomplete, I shall send patch v2 for it. Thanks. On 10/2/14 21:34, Chen Gang wrote: > SH_TIMER_CMT will use IO memory features which needs HAS_IOMEM, so need > depend on it. The related error (with allmodconfig under um): > > CC drivers/clocksource/sh_cmt.o > drivers/clocksource/sh_cmt.c: In function 'sh_cmt_map_memory': > drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function 'ioremap_nocache' [-Werror=implicit-function-declaration] > cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem)); > ^ > drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default] > cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem)); > ^ > drivers/clocksource/sh_cmt.c: In function 'sh_cmt_setup': > drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] > iounmap(cmt->mapbase); > ^ > > Signed-off-by: Chen Gang > --- > drivers/clocksource/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 82a2ebe..ee8aeeb 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -172,7 +172,7 @@ config SYS_SUPPORTS_EM_STI > > config SH_TIMER_CMT > bool "Renesas CMT timer driver" if COMPILE_TEST > - depends on GENERIC_CLOCKEVENTS > + depends on GENERIC_CLOCKEVENTS && HAS_IOMEM > default SYS_SUPPORTS_SH_CMT > help > This enables build of a clocksource and clockevent driver for > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed