[PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM

[PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM

[Chen Gang]

COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
with allmodconfig under um):

    CC [M]  drivers/staging/comedi/drivers/ii_pci20kc.o
  drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
  drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
    dev->mmio = ioremap(membase, II20K_SIZE);
    ^
  drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default]
    dev->mmio = ioremap(membase, II20K_SIZE);
              ^
  drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’:
  drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
     iounmap(dev->mmio);
     ^

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 drivers/staging/comedi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index a8bc2b5..b709736 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drivers/staging/comedi/Kconfig
@@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16
 
 config COMEDI_II_PCI20KC
 	tristate "Intelligent Instruments PCI-20001C carrier support"
+	depends on HAS_IOMEM
 	---help---
 	  Enable support for Intelligent Instruments PCI-20001C carrier
 	  PCI-20001, PCI-20006 and PCI-20341
-- 
1.9.3

RE: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM

[Hartley Sweeten]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1849 bytes --]

On Thursday, October 02, 2014 7:41 AM, Chen Gang wrote:
> COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
> with allmodconfig under um):
>
>     CC [M]  drivers/staging/comedi/drivers/ii_pci20kc.o
>   drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
>   drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
>     dev->mmio = ioremap(membase, II20K_SIZE);
>     ^
>   drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default]
>     dev->mmio = ioremap(membase, II20K_SIZE);
>               ^
>   drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’:
>   drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>      iounmap(dev->mmio);
>      ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  drivers/staging/comedi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index a8bc2b5..b709736 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16
>  
>  config COMEDI_II_PCI20KC
>  	tristate "Intelligent Instruments PCI-20001C carrier support"
> +	depends on HAS_IOMEM
>  	---help---
>  	  Enable support for Intelligent Instruments PCI-20001C carrier
>  	  PCI-20001, PCI-20006 and PCI-20341

This seems appropriate.

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM

[Rostislav Lisovy]

On Thu, 2014-10-02 at 17:01 +0000, Hartley Sweeten wrote:
> On Thursday, October 02, 2014 7:41 AM, Chen Gang wrote:
> > COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
> > with allmodconfig under um):
> >
> >     CC [M]  drivers/staging/comedi/drivers/ii_pci20kc.o
> >   drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
> >   drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> >     dev->mmio = ioremap(membase, II20K_SIZE);
> >     ^
> >   drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default]
> >     dev->mmio = ioremap(membase, II20K_SIZE);
> >               ^
> >   drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’:
> >   drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> >      iounmap(dev->mmio);
> >      ^
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > ---
> >  drivers/staging/comedi/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> > index a8bc2b5..b709736 100644
> > --- a/drivers/staging/comedi/Kconfig
> > +++ b/drivers/staging/comedi/Kconfig
> > @@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16
> >  
> >  config COMEDI_II_PCI20KC
> >  	tristate "Intelligent Instruments PCI-20001C carrier support"
> > +	depends on HAS_IOMEM
> >  	---help---
> >  	  Enable support for Intelligent Instruments PCI-20001C carrier
> >  	  PCI-20001, PCI-20006 and PCI-20341
> 
> This seems appropriate.
> 
> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> 

Since "egrep -irn "ioremap" drivers/staging/comedi/drivers | wc -l"
shows "39" does it mean that this should be added to all the other
drivers as well?

Rostislav Lisovy

RE: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM

[Hartley Sweeten]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 640 bytes --]

On Thursday, October 02, 2014 10:26 AM, Rostislav Lisovy wrote:
>
> Since "egrep -irn "ioremap" drivers/staging/comedi/drivers | wc -l"
> shows "39" does it mean that this should be added to all the other
> drivers as well?


The others are actually pci_ioremap_bar() and those drivers depend on PCI.
I don't _think_ these drivers require the depends on HAS_IOMEM.

The ii_pci20kc driver is goofy in that it's actually an ISA board that uses
memory mapped I/O.

Regards,
Hartley

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM

[Ian Abbott]

On 02/10/2014 15:41, Chen Gang wrote:
> COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
> with allmodconfig under um):
>
>      CC [M]  drivers/staging/comedi/drivers/ii_pci20kc.o
>    drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
>    drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
>      dev->mmio = ioremap(membase, II20K_SIZE);
>      ^
>    drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default]
>      dev->mmio = ioremap(membase, II20K_SIZE);
>                ^
>    drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’:
>    drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>       iounmap(dev->mmio);
>       ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>