public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
	hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
	luca.ellero@brickedbrain.com, lisovy@gmail.com
Cc: devel@driverdev.osuosl.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM
Date: Fri, 03 Oct 2014 12:39:30 +0100	[thread overview]
Message-ID: <542E8AF2.4030708@mev.co.uk> (raw)
In-Reply-To: <542D640E.6010200@gmail.com>

On 02/10/2014 15:41, Chen Gang wrote:
> COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
> with allmodconfig under um):
>
>      CC [M]  drivers/staging/comedi/drivers/ii_pci20kc.o
>    drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
>    drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
>      dev->mmio = ioremap(membase, II20K_SIZE);
>      ^
>    drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default]
>      dev->mmio = ioremap(membase, II20K_SIZE);
>                ^
>    drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’:
>    drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>       iounmap(dev->mmio);
>       ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

      parent reply	other threads:[~2014-10-03 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 14:41 [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM Chen Gang
2014-10-02 17:01 ` Hartley Sweeten
2014-10-02 17:26   ` Rostislav Lisovy
2014-10-02 17:44     ` Hartley Sweeten
2014-10-03 11:39 ` Ian Abbott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542E8AF2.4030708@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisovy@gmail.com \
    --cc=luca.ellero@brickedbrain.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox