From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753360AbaJCPVp (ORCPT ); Fri, 3 Oct 2014 11:21:45 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59245 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752489AbaJCPVn (ORCPT ); Fri, 3 Oct 2014 11:21:43 -0400 Message-ID: <542EBEF9.1070108@roeck-us.net> Date: Fri, 03 Oct 2014 08:21:29 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Mark Rutland CC: "atull@opensource.altera.com" , "broonie@kernel.org" , "jdelvare@suse.de" , "lm-sensors@lm-sensors.org" , "lgirdwood@gmail.com" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "delicious.quinoa@gmail.com" , "dinguyen@opensource.altera.com" , "yvanderv@opensource.altera.com" Subject: Re: [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation References: <1412275071-6417-1-git-send-email-atull@opensource.altera.com> <1412275071-6417-2-git-send-email-atull@opensource.altera.com> <20141003122736.GH26643@leverpostej> <542E9E9B.4090307@roeck-us.net> <20141003130559.GJ26643@leverpostej> In-Reply-To: <20141003130559.GJ26643@leverpostej> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020208.542EBF06.00B0,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 4 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/03/2014 06:05 AM, Mark Rutland wrote: > On Fri, Oct 03, 2014 at 02:03:23PM +0100, Guenter Roeck wrote: >> On 10/03/2014 05:27 AM, Mark Rutland wrote: >>> On Thu, Oct 02, 2014 at 07:37:48PM +0100, atull@opensource.altera.com wrote: >>>> From: Alan Tull >>>> >>>> Add device tree bindings documentation for ltc2978. >>>> >>>> Signed-off-by: Alan Tull >>>> --- >>>> v2: clean whitespace >>>> --- >>>> .../devicetree/bindings/hwmon/ltc2978.txt | 41 ++++++++++++++++++++ >>>> 1 file changed, 41 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/hwmon/ltc2978.txt b/Documentation/devicetree/bindings/hwmon/ltc2978.txt >>>> new file mode 100644 >>>> index 0000000..b2d9c4d >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/hwmon/ltc2978.txt >>>> @@ -0,0 +1,41 @@ >>>> +ltc2978 >>>> + >>>> +Required properties: >>>> + - compatible: one of: ltc2974, ltc2977, ltc2978, ltc3880, ltc3883, ltm4676 >>> >>> Could we please format this like: >>> >>> - compatible: should contain one of: >>> * "ltc2974" >>> * "ltc2977" >>> * "ltc2978" >>> * "ltc3880" >>> * "ltc3883" >>> * "ltm4676" >>> >>> Given the file name, are these all variants of ltc2978? >>> >> >> All the chips supported by the ltc2978 driver. Some are variants >> of the ltc2978, some have different functionality. > > Ok. > >> >> [ should those be "linear,ltc2974" and so on ? ] > > Good point; yes they should. That will need a vendor-prefixes.txt > addition. > Actually, turns out there already is one, only it is not immediately obvious: lltc for "Linear Technology Corporation". Guenter