From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760897AbaJDAA3 (ORCPT ); Fri, 3 Oct 2014 20:00:29 -0400 Received: from casper.infradead.org ([85.118.1.10]:37148 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758237AbaJDAA1 (ORCPT ); Fri, 3 Oct 2014 20:00:27 -0400 Message-ID: <542F3892.7090001@infradead.org> Date: Fri, 03 Oct 2014 17:00:18 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Josh Triplett CC: "Yann E. MORIN" , Andrew Morton , Eric Paris , Michal Hocko , Matt Turner , Paul Gortmaker , =?UTF-8?B?6JSh5q2j6b6Z?= , Tejun Heo , Fabian Frederick , "Luis R. Rodriguez" , Peter Foley , Konstantin Khlebnikov , "Eric W. Biederman" , "H. Peter Anvin" , Oleg Nesterov , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu References: <20141003233139.GA16079@thin> <542F3304.4000703@infradead.org> <20141003234743.GA16233@thin> In-Reply-To: <20141003234743.GA16233@thin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/03/14 16:47, Josh Triplett wrote: > On Fri, Oct 03, 2014 at 04:36:36PM -0700, Randy Dunlap wrote: >> On 10/03/14 16:31, Josh Triplett wrote: >>> commit 03b8c7b623c80af264c4c8d6111e5c6289933666 ("futex: Allow >>> architectures to skip futex_atomic_cmpxchg_inatomic() test") added the >>> HAVE_FUTEX_CMPXCHG symbol right below FUTEX. This placed it right in >>> the middle of the options for the EXPERT menu. However, >>> HAVE_FUTEX_CMPXCHG does not depend on EXPERT or FUTEX, so Kconfig stops >>> placing items in the EXPERT menu, and displays the remaining several >>> EXPERT items (starting with EPOLL) directly in the General Setup menu. >>> >>> Since both users of HAVE_FUTEX_CMPXCHG only select it "if FUTEX", make >>> HAVE_FUTEX_CMPXCHG itself depend on FUTEX. With this change, the >>> subsequent items display as part of the EXPERT menu again; the EMBEDDED >>> menu now appears as the next top-level item in the General Setup menu, >>> which makes General Setup much shorter and more usable. >>> >>> Signed-off-by: Josh Triplett >>> --- >>> >>> Posting for review. I can upstream this through the tiny tree. >>> >>> Personally, I'd consider this a bit of a bug in Kconfig; ideally, >>> Kconfig should only consider symbols with prompt strings when >>> considering what to display in a menu. However, in the interim, this >>> one-line patch drastically improves the usability of the "General Setup" >>> config menu. >> >> Good catch. Thanks. >> >> I would prefer to see both of your patches merged quickly into 3.17 no matter >> how they get there. >> >> both patches: >> Acked-by: Randy Dunlap > > Both of the fixes are entirely about Kconfig usability, don't affect the > built kernel, and have existed for quite a few kernel releases, so I > hadn't planned to get them into 3.17 at the last minute. I'd just > planned to submit them during the 3.18 merge window when that opens. > > Do you really think they should be pushed into 3.17 at this point? Both of them are bugs IMO, even though they are usability/presentation bugs. and they make the menu system confusing. > If you'd like, I could get them into 3.18 and mark them for stable, > instead. Do that at a minimum, please. -- ~Randy