public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cheng-wei Lee <lee.rhapsody@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	johannes.berg@intel.com, josh@joshtriplett.org,
	sarah.a.sharp@linux.intel.com, himangi774@gmail.com,
	teobaluta@gmail.com, linville@tuxdriver.com, gamerh2o@gmail.com
Cc: devel <devel@driverdev.osuosl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] drivers: staging: wlan-ng: fix sparse warnings
Date: Sat, 04 Oct 2014 10:24:28 +0800	[thread overview]
Message-ID: <542F5A5C.9050905@gmail.com> (raw)

This patch fix the sparse warnings in wlan-ng/cfg80211.c
The following functions were only used in this file, so done by
declaring them into static.

drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol
'prism2_connect_result' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol
'prism2_disconnected' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol
'prism2_roamed' was not declared. Should it be static?

Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
---
 drivers/staging/wlan-ng/cfg80211.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 723319e..9e65429 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -707,7 +707,7 @@ exit:
 
 
 /* Interface callback functions, passing data back up to the cfg80211 layer */
-void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
+static void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
 {
     u16 status = failed ?
              WLAN_STATUS_UNSPECIFIED_FAILURE : WLAN_STATUS_SUCCESS;
@@ -716,13 +716,13 @@ void prism2_connect_result(wlandevice_t *wlandev, u8 failed)
                 NULL, 0, NULL, 0, status, GFP_KERNEL);
 }
 
-void prism2_disconnected(wlandevice_t *wlandev)
+static void prism2_disconnected(wlandevice_t *wlandev)
 {
     cfg80211_disconnected(wlandev->netdev, 0, NULL,
         0, GFP_KERNEL);
 }
 
-void prism2_roamed(wlandevice_t *wlandev)
+static void prism2_roamed(wlandevice_t *wlandev)
 {
     cfg80211_roamed(wlandev->netdev, NULL, wlandev->bssid,
         NULL, 0, NULL, 0, GFP_KERNEL);
-- 
1.7.9.5

             reply	other threads:[~2014-10-04  2:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-04  2:24 Cheng-wei Lee [this message]
2014-10-08 22:57 ` [PATCH] drivers: staging: wlan-ng: fix sparse warnings Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2014-09-26 10:48 Cheng-Wei Lee
2014-09-26 11:02 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542F5A5C.9050905@gmail.com \
    --to=lee.rhapsody@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gamerh2o@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=himangi774@gmail.com \
    --cc=johannes.berg@intel.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=teobaluta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox