* [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue
@ 2014-10-04 13:11 Chen Gang
2014-10-24 22:52 ` Chen Gang
2015-05-31 19:48 ` Richard Weinberger
0 siblings, 2 replies; 3+ messages in thread
From: Chen Gang @ 2014-10-04 13:11 UTC (permalink / raw)
To: richard, jdike; +Cc: user-mode-linux-devel, user-mode-linux-user, linux-kernel
syscall() is implemented in libc.so/a (e.g. for glibc, in "syscall.o"),
so for normal ".o" files, it is undefined, neither can be found within
kernel wide, so will break modpost.
Since ".o" files is OK, can simply export 'syscall' symbol, let modpost
know about that, then can fix this issue.
The related error (with allmodconfig under um):
MODPOST 1205 modules
ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined!
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/um/kernel/ksyms.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/um/kernel/ksyms.c b/arch/um/kernel/ksyms.c
index 543c047..e7780f3 100644
--- a/arch/um/kernel/ksyms.c
+++ b/arch/um/kernel/ksyms.c
@@ -42,3 +42,6 @@ EXPORT_SYMBOL(os_makedev);
EXPORT_SYMBOL(add_sigio_fd);
EXPORT_SYMBOL(ignore_sigio_fd);
EXPORT_SYMBOL(sigio_broken);
+
+extern long int syscall (long int __sysno, ...);
+EXPORT_SYMBOL(syscall);
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue
2014-10-04 13:11 [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue Chen Gang
@ 2014-10-24 22:52 ` Chen Gang
2015-05-31 19:48 ` Richard Weinberger
1 sibling, 0 replies; 3+ messages in thread
From: Chen Gang @ 2014-10-24 22:52 UTC (permalink / raw)
To: richard, jdike; +Cc: user-mode-linux-devel, user-mode-linux-user, linux-kernel
Hello Maintainers:
Please help check this patch, when you have time.
Thanks.
On 10/4/14 21:11, Chen Gang wrote:
> syscall() is implemented in libc.so/a (e.g. for glibc, in "syscall.o"),
> so for normal ".o" files, it is undefined, neither can be found within
> kernel wide, so will break modpost.
>
> Since ".o" files is OK, can simply export 'syscall' symbol, let modpost
> know about that, then can fix this issue.
>
> The related error (with allmodconfig under um):
>
> MODPOST 1205 modules
> ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined!
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/um/kernel/ksyms.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/um/kernel/ksyms.c b/arch/um/kernel/ksyms.c
> index 543c047..e7780f3 100644
> --- a/arch/um/kernel/ksyms.c
> +++ b/arch/um/kernel/ksyms.c
> @@ -42,3 +42,6 @@ EXPORT_SYMBOL(os_makedev);
> EXPORT_SYMBOL(add_sigio_fd);
> EXPORT_SYMBOL(ignore_sigio_fd);
> EXPORT_SYMBOL(sigio_broken);
> +
> +extern long int syscall (long int __sysno, ...);
> +EXPORT_SYMBOL(syscall);
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue
2014-10-04 13:11 [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue Chen Gang
2014-10-24 22:52 ` Chen Gang
@ 2015-05-31 19:48 ` Richard Weinberger
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2015-05-31 19:48 UTC (permalink / raw)
To: Chen Gang, jdike
Cc: user-mode-linux-devel, user-mode-linux-user, linux-kernel,
Thomas Meyer
Am 04.10.2014 um 15:11 schrieb Chen Gang:
> syscall() is implemented in libc.so/a (e.g. for glibc, in "syscall.o"),
> so for normal ".o" files, it is undefined, neither can be found within
> kernel wide, so will break modpost.
>
> Since ".o" files is OK, can simply export 'syscall' symbol, let modpost
> know about that, then can fix this issue.
>
> The related error (with allmodconfig under um):
>
> MODPOST 1205 modules
> ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined!
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/um/kernel/ksyms.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/um/kernel/ksyms.c b/arch/um/kernel/ksyms.c
> index 543c047..e7780f3 100644
> --- a/arch/um/kernel/ksyms.c
> +++ b/arch/um/kernel/ksyms.c
> @@ -42,3 +42,6 @@ EXPORT_SYMBOL(os_makedev);
> EXPORT_SYMBOL(add_sigio_fd);
> EXPORT_SYMBOL(ignore_sigio_fd);
> EXPORT_SYMBOL(sigio_broken);
> +
> +extern long int syscall (long int __sysno, ...);
> +EXPORT_SYMBOL(syscall);
Thanks Chen, applied to my 4.2 queue!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-31 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-04 13:11 [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue Chen Gang
2014-10-24 22:52 ` Chen Gang
2015-05-31 19:48 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).