[PATCH 07/16] i3c: mipi-i3c-hci: Complete transfer lists immediately on error

Adrian Hunter
2026-04-16T17:57:30Z

In DMA mode, transfer lists are currently completed only when the final
transfer in the list completes. If an earlier transfer fails, the list is
left incomplete and callers wait until timeout.

There is no need to wait for a timeout, as the completion path in
i3c_hci_process_xfer() already checks for error status. Complete the
transfer list as soon as any transfer in the list reports an error.

This avoids unnecessary delays and spurious timeouts on error.

Complete a transfer list completion immediately there is an error.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
drivers/i3c/master/mipi-i3c-hci/dma.c | 6 ++++--
drivers/i3c/master/mipi-i3c-hci/hci.h | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
index 28e4d38f55d3..5eea4fe6ebb3 100644
--- a/drivers/i3c/master/mipi-i3c-hci/dma.c
+++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
@@ -502,6 +502,8 @@ static int hci_dma_queue_xfer(struct i3c_hci *hci,
struct hci_xfer *xfer = xfer_list + i;
u32 *ring_data = rh->xfer + rh->xfer_struct_sz * enqueue_ptr;

+ xfer->completing_xfer = xfer_list + n - 1;
+
/* store cmd descriptor */
*ring_data++ = xfer->cmd_desc[0];
*ring_data++ = xfer->cmd_desc[1];
@@ -576,8 +578,8 @@ static void hci_dma_xfer_done(struct i3c_hci *hci, struct hci_rh_data *rh)
tid, xfer->cmd_tid);
/* TODO: do something about it? */
}
- if (xfer->completion)
- complete(xfer->completion);
+ if (xfer == xfer->completing_xfer || RESP_STATUS(resp))
+ complete(xfer->completing_xfer->completion);
if (RESP_STATUS(resp))
hci->enqueue_blocked = true;
}
diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h
index d630400ec945..eee3e11810dd 100644
--- a/drivers/i3c/master/mipi-i3c-hci/hci.h
+++ b/drivers/i3c/master/mipi-i3c-hci/hci.h
@@ -104,6 +104,7 @@ struct hci_xfer {
struct {
/* DMA specific */
struct i3c_dma *dma;
+ struct hci_xfer *completing_xfer;
int ring_number;
int ring_entry;
};
--
2.51.0