From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756523AbaJHOjC (ORCPT ); Wed, 8 Oct 2014 10:39:02 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:52514 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbaJHOjA (ORCPT ); Wed, 8 Oct 2014 10:39:00 -0400 Message-ID: <54354C7D.7090104@collabora.co.uk> Date: Wed, 08 Oct 2014 16:38:53 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: Mark Brown CC: Doug Anderson , Chanwoo Choi , Olof Johansson , Chris Zhong , Krzysztof Kozlowski , Abhilash Kesavan , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/5] regulator: of: Add regulator-initial-mode parse support References: <1412775847-15213-1-git-send-email-javier.martinez@collabora.co.uk> <1412775847-15213-2-git-send-email-javier.martinez@collabora.co.uk> <20141008142511.GA4609@sirena.org.uk> In-Reply-To: <20141008142511.GA4609@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, Thanks for the feedback. On 10/08/2014 04:25 PM, Mark Brown wrote: > On Wed, Oct 08, 2014 at 03:44:03PM +0200, Javier Martinez Canillas wrote: > >> But currently there isn't a way to do the same with DeviceTrees. Argubly >> the operating modes are Linux-specific so that information should not be >> in the DT which should be used to only describe hardware. But regulators >> having different operating modes is also a hardware property since many >> PMICs have support to set different modes for their regulators. > > That doesn't mean that the definition of those modes is something we can > sensibly provide in generic code, especially in a completely > undocumented fashion (perhaps you've done that later in the patch series > but bisection also applies to reviewability). > Yes, patch #3 updates the regulator DT binding doc and documents what each regulator mode is supposed to be. Basically is just a short description of what is already documented in linux/regulator/consumer.h [0]. If what is enough for you I can reorganize the patch-set so that patch is the first one. As a general question, now that the convention is for DT binding docs to go in a separate patch, should the DT documentation be added before or after that code using these bindings is added? That is something that is not explained in Documentation/devicetree/bindings/submitting-patches.txt. Best regards, Javier [0]: http://lxr.free-electrons.com/source/include/linux/regulator/consumer.h#L40