From: Rik van Riel <riel@redhat.com>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
mingo@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, tkhai@yandex.ru
Subject: Re: [PATCH] sched/fair: Care divide error in update_task_scan_period()
Date: Wed, 08 Oct 2014 12:42:24 -0400 [thread overview]
Message-ID: <54356970.7050805@redhat.com> (raw)
In-Reply-To: <5434DCFF.1040208@jp.fujitsu.com>
On 10/08/2014 02:43 AM, Yasuaki Ishimatsu wrote:
> The divide error is rare case because the trigger is node offline.
> By this patch, when both of private and shared are set to 0, diff
> is just set to 0, not calculating the division.
How about a simple
if (private + shared) == 0)
return;
higher up in the function, to avoid adding an extra
layer of indentation and confusion to the main part
of the function?
next prev parent reply other threads:[~2014-10-08 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 6:43 [PATCH] sched/fair: Care divide error in update_task_scan_period() Yasuaki Ishimatsu
2014-10-08 8:31 ` Peter Zijlstra
2014-10-08 11:51 ` Wanpeng Li
2014-10-09 5:34 ` Yasuaki Ishimatsu
2014-10-08 16:42 ` Rik van Riel [this message]
2014-10-08 16:54 ` Peter Zijlstra
2014-10-09 5:19 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54356970.7050805@redhat.com \
--to=riel@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox