Re: [PATCH v7 5/6] arm64: add SIGSYS siginfo for compat task

AKASHI Takahiro
2014-10-09T02:26:13Z

On 10/08/2014 11:30 PM, Will Deacon wrote:
> On Thu, Oct 02, 2014 at 10:46:15AM +0100, AKASHI Takahiro wrote:
>> SIGSYS is primarily used in secure computing to notify tracer.
>> This patch allows signal handler on compat task to get correct information
>> with SA_SIGINFO specified when this signal is delivered.
>>
>> Reviewed-by: Kees Cook <keescook@chromium.org>
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>> ---
>> arch/arm64/include/asm/compat.h | 7 +++++++
>> arch/arm64/kernel/signal32.c | 6 ++++++
>> 2 files changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/include/asm/compat.h b/arch/arm64/include/asm/compat.h
>> index 253e33b..c877915 100644
>> --- a/arch/arm64/include/asm/compat.h
>> +++ b/arch/arm64/include/asm/compat.h
>> @@ -205,6 +205,13 @@ typedef struct compat_siginfo {
>> compat_long_t _band; /* POLL_IN, POLL_OUT, POLL_MSG */
>> int _fd;
>> } _sigpoll;
>> +
>> + /* SIGSYS */
>> + struct {
>> + compat_uptr_t _call_addr; /* calling user insn */
>> + int _syscall; /* triggering system call number */
>> + unsigned int _arch; /* AUDIT_ARCH_* of syscall */
>
> nit, but compat_uint_t looks better here (I have no idea why I didn't do
> this for the signed int types, but hey).

I will fix it.

-Takahiro AKASHI

> Will
>