public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ray Jui <rjui@broadcom.com>
To: Dan Williams <djbw@fb.com>, Vinod Koul <vinod.koul@intel.com>
Cc: Scott Branden <sbranden@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, <linux-kernel@vger.kernel.org>
Subject: Consider moving the init of pl330 to earlier?
Date: Thu, 9 Oct 2014 14:35:11 -0700	[thread overview]
Message-ID: <5436FF8F.8060602@broadcom.com> (raw)

Hi,

How do you guys like the idea of moving the driver initialization of the 
pl330 DMA driver to earlier? For example, to arch_initcall_sync or 
subsys_initcall? Currently the pl330 driver is registered through 
module_amba_driver call, which translates to device_initcall in the end. 
This is a bit late considering in many systems, DMA controller is one of 
the core components that may have many slave devices depending on. Most 
slave drivers are typically done at device_initcall. When done at the 
same level, DMA may not be ready while the slave devices are being 
initialized. In addition, under the drivers/dma directory, we currently 
have various other DMA drivers also done at subsys_initcall.

One issue that I'm seeing with the Broadcom Cygnus SoC is that, when we 
try to use DMA with SPI (PL022), the request for DMA channel would fail 
because the spi-pl022 driver we use is initialized at subsys_initcall. 
At the time the PL330 driver is not yet initialized. The reason why 
spi-pl022 is done at subsys_initcall is that some regulators communicate 
through the SPI bus so people decided to move it to earlier (commit 
25c8e03b by Linus Walleij), which seems to be a valid reason to me.

Thanks,

Ray

             reply	other threads:[~2014-10-09 21:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09 21:35 Ray Jui [this message]
2014-10-16  6:59 ` Consider moving the init of pl330 to earlier? Vinod Koul
2014-10-16 16:00   ` Ray Jui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5436FF8F.8060602@broadcom.com \
    --to=rjui@broadcom.com \
    --cc=djbw@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox