From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbaJLT7T (ORCPT ); Sun, 12 Oct 2014 15:59:19 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:50597 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbaJLT7P (ORCPT ); Sun, 12 Oct 2014 15:59:15 -0400 Message-ID: <543ADD89.1050702@roeck-us.net> Date: Sun, 12 Oct 2014 12:59:05 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Len Brown , Pavel Machek , Andrew Morton Subject: Re: [RFC PATCH 1/2] acpi: Use syscore instead of pm_power_off_prepare to prepare for poweroff References: <1413062057-11657-1-git-send-email-linux@roeck-us.net> <3090667.ydmQKSGePB@vostro.rjw.lan> <543AD7FA.5060706@roeck-us.net> <2189351.ETD7m2XsWr@vostro.rjw.lan> In-Reply-To: <2189351.ETD7m2XsWr@vostro.rjw.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.543ADD93.00A1,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 5 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2014 01:16 PM, Rafael J. Wysocki wrote: > On Sunday, October 12, 2014 12:35:22 PM Guenter Roeck wrote: >> On 10/12/2014 12:45 PM, Rafael J. Wysocki wrote: >>> On Saturday, October 11, 2014 02:14:16 PM Guenter Roeck wrote: >>>> The syscore shutdown callback seems to be perfectly suited to prepare for system >>>> poweroff. Use it instead of pm_power_off_prepare. >>> >>> How much testing did that receive? >>> >> >> As I mentioned in patch 0/2, compile tested so far only. Before I start playing >> with my servers, I wanted to get some feedback if the idea is worth pursuing >> further or if I am missing something essential. > > Well, it makes sense in principle, but the ordering with respect to the other > syscore shutdown things and the migrate_to_reboot_cpu() may be a problem. > > I always get nervous when the ordering of ACPI-related code changes like > that and the reason is quite weak this time to be honest. > Ok, no problem; I'll drop it. Guenter