From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Vinod Koul <vinod.koul@intel.com>, <dmaengine@vger.kernel.org>
Cc: Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/12] spi/atmel: use dmaengine_terminate_all() API
Date: Sun, 12 Oct 2014 22:06:01 +0200 [thread overview]
Message-ID: <543ADF29.9090307@atmel.com> (raw)
In-Reply-To: <1413042040-28222-7-git-send-email-vinod.koul@intel.com>
On 11/10/2014 17:40, Vinod Koul :
> The drivers should use dmaengine_terminate_all() API instead of
> accessing the device_control which will be deprecated soon
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
sure:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks Vinod.
Bye,
> ---
> drivers/spi/spi-atmel.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 113c83f..649dcb5 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -482,11 +482,9 @@ error:
> static void atmel_spi_stop_dma(struct atmel_spi *as)
> {
> if (as->dma.chan_rx)
> - as->dma.chan_rx->device->device_control(as->dma.chan_rx,
> - DMA_TERMINATE_ALL, 0);
> + dmaengine_terminate_all(as->dma.chan_rx);
> if (as->dma.chan_tx)
> - as->dma.chan_tx->device->device_control(as->dma.chan_tx,
> - DMA_TERMINATE_ALL, 0);
> + dmaengine_terminate_all(as->dma.chan_tx);
> }
>
> static void atmel_spi_release_dma(struct atmel_spi *as)
>
--
Nicolas Ferre
next prev parent reply other threads:[~2014-10-12 20:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
2014-10-11 15:40 ` [PATCH 01/12] pata_arasan_cf: use dmaengine_terminate_all() API Vinod Koul
2014-10-13 2:47 ` Viresh Kumar
2014-10-11 15:40 ` [PATCH 02/12] dmaengine: coh901318: " Vinod Koul
2014-10-27 16:43 ` Linus Walleij
2014-10-11 15:40 ` [PATCH 03/12] [media] V4L2: mx3_camer: use dmaengine_pause() API Vinod Koul
2014-10-16 19:40 ` Guennadi Liakhovetski
2014-10-11 15:40 ` [PATCH 04/12] mtd: fsmc_nand: use dmaengine_terminate_all() API Vinod Koul
2014-10-27 16:43 ` Linus Walleij
2014-10-11 15:40 ` [PATCH 05/12] mtd: sh_flctl: " Vinod Koul
2014-10-11 17:19 ` Laurent Pinchart
2014-10-11 15:40 ` [PATCH 06/12] net: ks8842: " Vinod Koul
2014-10-11 15:40 ` [PATCH 07/12] spi/atmel: " Vinod Koul
2014-10-12 20:06 ` Nicolas Ferre [this message]
2014-10-13 10:30 ` Mark Brown
2014-10-11 15:40 ` [PATCH 08/12] spi/spi-dw-mid.c: use dmaengine_slave_config() API Vinod Koul
2014-10-13 10:32 ` Mark Brown
2014-10-11 15:40 ` [PATCH 09/12] serial: sh-sci: use dmaengine_terminate_all() API Vinod Koul
2014-10-11 20:21 ` Greg Kroah-Hartman
2014-10-11 15:40 ` [PATCH 10/12] usb: musb: ux500_dma: use dmaengine_xxx() APIs Vinod Koul
2014-10-11 20:21 ` Greg Kroah-Hartman
2014-10-12 0:45 ` Felipe Balbi
2014-10-11 15:40 ` [PATCH 11/12] ASoC: txx9: use dmaengine_terminate_all() API Vinod Koul
2014-10-11 16:21 ` Lars-Peter Clausen
2014-10-11 15:54 ` Vinod Koul
2014-10-13 7:44 ` Mark Brown
2014-10-11 15:40 ` [PATCH 12/12] video: mx3fb: " Vinod Koul
2014-10-15 15:58 ` [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543ADF29.9090307@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=broonie@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).