Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

[Mark Hounschell <markh@compro.net>]

On 10/13/2014 10:04 PM, Greg KH wrote:
> On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
>> On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
>>> Hi,
>>>
>>> 2014-10-13 12:25 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
>>>> On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
>>>>> Re-arrange the functions for removing forward declarations.
>>>>>
>>>>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>>>>> ---
>>>>> This patch has too many changes for re-arranging the functions.
>>>>> So I wonder that I should break this up into smaller patches.
>>>>
>>>> Are the .o files identical before and after this patch?  If so, it's
>>>> fine.
>>> Ok. I will check for that.
>>
>> The .o files shouldn't be identical after function reordering.
>
> Hm, they might be the same size, but I can see how on some
> architectures (like ppc) how that would not be the case, you are right.
>
> Isn't there an "objdiff" program or something like that which might help
> in validating that nothing "changed" in the source for type of patch
> that just moves functions around in a file.
>
> thanks,
>

Greg,

Would just testing the thing be of any help?

Regards
Mark