From: David Vrabel <david.vrabel@citrix.com>
To: <hansechang@gmail.com>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xen.org>
Cc: Chang Huaixin <huaixin.chx@alibaba-inc.com>,
<jinsong.liu@alibaba-inc.com>, <Ian.Campbell@eu.citrix.com>,
<david.vrabel@citrix.com>, <dgdegra@tycho.nsa.gov>,
<boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH] Input: xen-kbdfront - free grant table entry in xenkbd_disconnect_backend
Date: Thu, 16 Oct 2014 17:01:09 +0100 [thread overview]
Message-ID: <543FEBC5.2050202@citrix.com> (raw)
In-Reply-To: <1413423992-3005-1-git-send-email-hansechang@gmail.com>
On 16/10/14 02:46, hansechang@gmail.com wrote:
> From: Chang Huaixin <huaixin.chx@alibaba-inc.com>
>
> xenkbd_disconnect_backend doesn't free grant table entry.
> This bug affects live migration.
>
> xenkbd_disconnect_backend uses gnttab_end_foreign_access_ref
> to handle grant table entry which doesn't really free an entry.
>
> Thus every time we do xenkbd_resume, grant table entry increses
> by one. As an grant table entry occupies 8 bytes, an grant table
> page has at most 512 entries. Every 512 times we do xenkdb_resume,
> grant table pages increses by one.
>
> After around 3500 times of live migration, grant table pages
> will increase by 7, causing too many pages to populate and hitting
> max_pages limit when assigning pages.Thus assign_pages will fail,
> so will live migration.
Acked-by: David Vrabel <david.vrabel@citrix.com>
This need to be send to the input subsystem maintainers.
David
next prev parent reply other threads:[~2014-10-16 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 1:46 [PATCH] Input: xen-kbdfront - free grant table entry in xenkbd_disconnect_backend hansechang
2014-10-16 16:01 ` David Vrabel [this message]
2014-10-16 20:37 ` [Xen-devel] " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543FEBC5.2050202@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=hansechang@gmail.com \
--cc=huaixin.chx@alibaba-inc.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox