From: Chanwoo Choi <cw00.choi@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH] extcon: Implement OF-based extcon lookup properly
Date: Fri, 17 Oct 2014 08:32:26 +0900 [thread overview]
Message-ID: <5440558A.3080202@samsung.com> (raw)
In-Reply-To: <1413465104-26201-1-git-send-email-m.szyprowski@samsung.com>
On 10/16/2014 10:11 PM, Marek Szyprowski wrote:
> From: Tomasz Figa <tomasz.figa@gmail.com>
>
> Platform bus is not the only way to have extcon devices, so current
> implementation of of_extcon_get_extcon_dev() is broken. Also using
> parent device node only to get device name is quite ugly.
>
> This patch reimplements of_extcon_get_extcon_dev() to do exactly the
> same as extcon_get_extcon_dev() but instead of comparing names, compare
> node pointers.
>
> Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
> [mszyprow: simplified the code]
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/extcon/extcon-class.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
Applied it. Thank you.
Chanwoo Choi
prev parent reply other threads:[~2014-10-16 23:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 13:11 [PATCH] extcon: Implement OF-based extcon lookup properly Marek Szyprowski
2014-10-16 23:32 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5440558A.3080202@samsung.com \
--to=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox