From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446AbaJQKJh (ORCPT ); Fri, 17 Oct 2014 06:09:37 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:17723 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750835AbaJQKJf (ORCPT ); Fri, 17 Oct 2014 06:09:35 -0400 Message-ID: <5440EAD8.4060801@fb.com> Date: Fri, 17 Oct 2014 06:09:28 -0400 From: Chris Mason User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Linus Torvalds , Linux Kernel Mailing List , linux-btrfs Subject: Re: [GIT PULL] Btrfs corruption fix References: <543F78F1.6040203@fb.com> In-Reply-To: <543F78F1.6040203@fb.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.16.4] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52,1.0.28,0.0.0000 definitions=2014-10-17_03:2014-10-17,2014-10-17,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 kscore.is_bulkscore=1.332078891636e-11 kscore.compositescore=0 circleOfTrustscore=29.4129509548051 compositescore=0.998049563855454 urlsuspect_oldscore=0.998049563855454 suspectscore=2 recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 recipient_to_sender_totalscore=0 recipient_domain_to_sender_domain_totalscore=64355 rbsscore=0.998049563855454 spamscore=0 recipient_to_sender_domain_totalscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1410170099 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2014 03:51 AM, Chris Mason wrote: > Hi Linus, > > I'm testing a pull with more fixes, but wanted to get this one out so > Greg can pick it up. The corruption isn't easy to hit, you have to do a > readonly snapshot and have orphans in the snapshot. But my review and > testing missed the bug. Filipe has added a better xfstest to cover it. > > Please pull: > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Sorry Linus, I realized this morning I forgot my sob. I've pushed out an updated commit to a new for-linus-update branch. The code and diffstat are exactly the same: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-update > > Chris Mason (1) commits (+33/-36): > Revert "Btrfs: race free update of commit root for ro snapshots" > > Total: (1) commits (+33/-36) > > fs/btrfs/inode.c | 36 ------------------------------------ > fs/btrfs/ioctl.c | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+), 36 deletions(-) > -chris