From: David Vrabel <david.vrabel@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<david.vrabel@citrix.com>, <konrad.wilk@oracle.com>
Cc: <cl@linux.com>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH] xen/time: Fix incorrect per_cpu accessor in xen_clocksource_read()
Date: Fri, 17 Oct 2014 13:45:47 +0100 [thread overview]
Message-ID: <54410F7B.6040803@citrix.com> (raw)
In-Reply-To: <1413493335-6110-1-git-send-email-boris.ostrovsky@oracle.com>
On 16/10/14 22:02, Boris Ostrovsky wrote:
> Commit 89cbc76768c2 ("x86: Replace __get_cpu_var uses") replaced
> __get_cpu_var() with this_cpu_ptr() in xen_clocksource_read() in such a
> way that instead of accessing a structure pointed to by a per-cpu pointer
> we are trying to get to a per-cpu structure.
>
> __this_cpu_read() of the pointer is the more appropriate accessor.
Applied, thanks.
David
prev parent reply other threads:[~2014-10-17 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 21:02 [PATCH] xen/time: Fix incorrect per_cpu accessor in xen_clocksource_read() Boris Ostrovsky
2014-10-17 12:45 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54410F7B.6040803@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=cl@linux.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox