From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090AbaJUArH (ORCPT ); Mon, 20 Oct 2014 20:47:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26196 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753038AbaJUArF (ORCPT ); Mon, 20 Oct 2014 20:47:05 -0400 Message-ID: <5445AD03.6000901@redhat.com> Date: Mon, 20 Oct 2014 20:46:59 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131028 Thunderbird/17.0.10 MIME-Version: 1.0 To: Joe Perches CC: linux-kernel@vger.kernel.org, Andy Whitcroft Subject: Re: [PATCH] scripts, checkpatch.pl, provide a better output message for commit id format [v2] References: <1413845376-2128-1-git-send-email-prarit@redhat.com> <1413846680.5407.4.camel@perches.com> In-Reply-To: <1413846680.5407.4.camel@perches.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20/2014 07:11 PM, Joe Perches wrote: > On Mon, 2014-10-20 at 18:49 -0400, Prarit Bhargava wrote: >> I tested this using both lower and upper case 'c' with the following commit >> text: > [] > > I think the patch subject be something like: > > "[PATCH] checkpatch: improve commit id/desc style checking in commit message" > > The [v2] goes in the subject like this: > > "[PATCH V2] checkpatch: ..." > >> 11 chars, SHOULD FAIL >> commit 1234567890a > > [] > >> ERROR: Please use 12 or more chars for the git commit ID >> commit 1234567890a > > I'd expect these messages to mention something about the > missing commit description too. Hmm ... is that a requirement here? Currently checkpatch.pl doesn't complain about that. I can do it but I'd hate to find out that I'm ERRORing on something that is considered okay to do. P. > >