From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter Zijlstra <peterz@infradead.org>,
Pranith Kumar <bobby.prani@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
Borislav Petkov <bp@suse.de>,
"open list:X86 ARCHITECTURE..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cmpxchg: Discard unnecessary cast to volatile
Date: Tue, 21 Oct 2014 08:48:51 -0700 [thread overview]
Message-ID: <54468063.4070408@zytor.com> (raw)
In-Reply-To: <20141021101412.GS23531@worktop.programming.kicks-ass.net>
On 10/21/2014 03:14 AM, Peter Zijlstra wrote:
> On Mon, Oct 20, 2014 at 04:22:27PM -0400, Pranith Kumar wrote:
>>> Generating a volatile pointer is really not necessary here. This is the only
>>> location where a volatile pointer is being generated for use in asm.
>>>
>>> This commit removes the unnecessary volatile pointer being created.
>>>
>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>
> Seems sane enough to me.
>
However, it seems like unnecessary churn. Does the volatile hurt in any
way?
-hpa
next prev parent reply other threads:[~2014-10-21 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 17:57 [PATCH] cmpxchg: Discard unnecessary cast to volatile Pranith Kumar
2014-10-20 20:22 ` Pranith Kumar
2014-10-21 10:14 ` Peter Zijlstra
2014-10-21 15:48 ` H. Peter Anvin [this message]
2014-10-21 22:15 ` Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54468063.4070408@zytor.com \
--to=hpa@zytor.com \
--cc=bobby.prani@gmail.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).