From: Jens Axboe <axboe@kernel.dk>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: wrong return value
Date: Thu, 23 Oct 2014 08:12:06 -0600 [thread overview]
Message-ID: <54490CB6.80306@kernel.dk> (raw)
In-Reply-To: <1414070409-4566-1-git-send-email-sudipm.mukherjee@gmail.com>
On 10/23/2014 07:20 AM, Sudip Mukherjee wrote:
> while compiling integer err was showing as a set but unused variable.
> elevator_init_fn can be either cfq_init_queue or deadline_init_queue
> or noop_init_queue.
> all three of these functions are returning -ENOMEM if they fail to
> allocate the queue.
> so we should actually be returning the error code rather than
> returning 0 always.
That does look weird. You need an elevator_put() in the error case,
though, ala:
err = e->ops.elevator_init_fn(q, e);
if (err)
elevator_put(e);
return err;
--
Jens Axboe
next prev parent reply other threads:[~2014-10-23 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 13:20 [PATCH] block: wrong return value Sudip Mukherjee
2014-10-23 14:12 ` Jens Axboe [this message]
2014-10-23 15:08 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54490CB6.80306@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox